public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: subsystem_unregister() breakage in -mm
Date: Wed, 26 Sep 2007 08:14:58 -0700	[thread overview]
Message-ID: <20070926151458.GA10460@kroah.com> (raw)
In-Reply-To: <20070926092156.2f281eea@gondolin.boeblingen.de.ibm.com>

On Wed, Sep 26, 2007 at 09:21:56AM +0200, Cornelia Huck wrote:
> On Tue, 25 Sep 2007 19:41:21 -0700,
> Greg KH <greg@kroah.com> wrote:
> 
> > Ok, here's a patch that fixes this for me.  It should go on top of the
> > -mm tree.  Let me know of this works or not.
> 
> Looks sane to me.
> 
> > In the end, we need to dynamically allocate these subsystems to properly
> > fix this.  In looking through the tree, there really isn't that many of
> > them, so I'll try to knock that out later this week.
> 
> What they need at least is a dynamically allocated k_name.

Yes :(

> Same goes
> for all those objects that use set_kset_name(), and there are quite a
> few of those...

Almost all of those are the stupid sysdev_class and sys_device stuff.  I
_really_ want to get rid of those as they should be a "normal"
device/driver/class.  I think Adam Belay has some patches he is working
on to get rid of these, but I do not know the status of them.

Anyway, they are static structures, so my fix will keep them from
oopsing.

thanks,

greg k-h

  reply	other threads:[~2007-09-26 15:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-25 22:27 subsystem_unregister() breakage in -mm Miklos Szeredi
2007-09-25 22:53 ` Greg KH
2007-09-25 23:02   ` Miklos Szeredi
2007-09-26  0:36     ` Greg KH
2007-09-26  2:41     ` Greg KH
2007-09-26  7:21       ` Cornelia Huck
2007-09-26 15:14         ` Greg KH [this message]
2007-09-26  8:17       ` Miklos Szeredi
2007-09-26 15:15         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070926151458.GA10460@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@linux-foundation.org \
    --cc=cornelia.huck@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox