From: Al Viro <viro@ftp.linux.org.uk>
To: Andrew Morgan <morgan@kernel.org>
Cc: David Howells <dhowells@redhat.com>,
hch@infradead.org, Trond.Myklebust@netapp.com, sds@tycho.nsa.gov,
casey@schaufler-ca.com, linux-kernel@vger.kernel.org,
selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org
Subject: Re: [PATCH 3/3] CRED: Move the effective capabilities into the cred struct
Date: Wed, 26 Sep 2007 19:23:22 +0100 [thread overview]
Message-ID: <20070926182322.GQ8181@ftp.linux.org.uk> (raw)
In-Reply-To: <46F1F2EE.1010904@kernel.org>
On Wed, Sep 19, 2007 at 09:11:26PM -0700, Andrew Morgan wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> David Howells wrote:
> > Move the effective capabilities mask from the task struct into the credentials
> > record.
> >
> > Note that the effective capabilities mask in the cred struct shadows that in
> > the task_struct because a thread can have its capabilities masks changed by
> > another thread. The shadowing is performed by update_current_cred() which is
> > invoked on entry to any system call that might need it.
>
> OOC If we were to simply drop support for one process changing the
> capabilities of another, would we need this patch?
Umm... It would become simpler (which is a damn good thing - less PITA
with update_current_cred), but it would be still needed.
FWIW, dropping that support would be a Good Thing(tm), as far as I'm
concerned. _Why_ do we want that, anyway, and how much userland code
is able to cope with that in sane way?
prev parent reply other threads:[~2007-09-26 18:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-19 16:17 [PATCH 0/3] Introduce credential record David Howells
2007-09-19 16:17 ` [PATCH 1/3] CRED: Introduce a COW credentials record David Howells
2007-09-19 16:18 ` [PATCH 2/3] CRED: Split the task security data and move part of it into struct cred David Howells
2007-09-19 17:28 ` Casey Schaufler
2007-09-19 22:57 ` David Howells
2007-09-20 16:31 ` Casey Schaufler
2007-09-20 17:17 ` David Howells
2007-09-20 17:33 ` David Howells
2007-09-24 14:00 ` Serge E. Hallyn
2007-09-24 14:21 ` Stephen Smalley
2007-09-24 15:35 ` Serge E. Hallyn
2007-09-24 15:52 ` David Howells
2007-09-26 13:30 ` David Howells
2007-09-26 14:14 ` Stephen Smalley
2007-09-26 14:58 ` Casey Schaufler
2007-09-19 16:18 ` [PATCH 3/3] CRED: Move the effective capabilities into the cred struct David Howells
2007-09-20 4:11 ` Andrew Morgan
2007-09-20 8:15 ` David Howells
2007-09-20 13:38 ` Trond Myklebust
2007-09-20 15:36 ` Casey Schaufler
2007-09-20 16:09 ` Trond Myklebust
2007-09-26 18:23 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070926182322.GQ8181@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=Trond.Myklebust@netapp.com \
--cc=casey@schaufler-ca.com \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=morgan@kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox