Re: [PATCH] Add iSCSI iBFT support.

[Konrad Rzeszutek <konrad@darnok.org>]

On Wednesday 26 September 2007 17:10:57 Greg KH wrote:
> On Wed, Sep 26, 2007 at 02:46:52PM -0400, Konrad Rzeszutek wrote:
> > This patch adds a /sysfs/firmware/ibft/table binary blob which exports
> > the iSCSI Boot Firmware Table (iBFT) structure.
>
> Please don't do that.  Binary files are for things that are
> "pass-through" only, not anything that the kernel knows the structure
> of, or cares about (like PCI config space, or firmware blobs for
> devices.)
>
> Just export the individual fields of this table as individual files
> please.

My goal was to do that in the next version of this patch. My first step was
to get the fundamental work reviewed (and hopefully accepted) and then build 
on top of that.

The exploiter of this binary file (/sys/firmware/ibft/table) is the 
iscsi-initiator-utils package and it has a library that parses the binary 
blob data. The thought was to get this first working (ie, 
iscsi-initiator-utils finds /sys/firmware/ibft/table, parses it and work) and 
then work to have the iscsi-initiator-support individual sysfs entries.

Or do you think I should skip the fundamental step and work on the next
version of this patch that exports the data as individual data and post that
one instead?

>
> thanks,
>
> greg k-h