public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Konrad Rzeszutek <konrad@darnok.org>
Cc: linux-kernel@vger.kernel.org, pjones@redhat.com,
	konradr@redhat.com, konradr@linux.vnet.ibm.com
Subject: Re: [PATCH] Add iSCSI iBFT support.
Date: Wed, 26 Sep 2007 14:10:57 -0700	[thread overview]
Message-ID: <20070926211057.GA3050@kroah.com> (raw)
In-Reply-To: <20070926184652.GA16369@andromeda.dapyr.net>

On Wed, Sep 26, 2007 at 02:46:52PM -0400, Konrad Rzeszutek wrote:
> This patch adds a /sysfs/firmware/ibft/table binary blob which exports
> the iSCSI Boot Firmware Table (iBFT) structure. 

Please don't do that.  Binary files are for things that are
"pass-through" only, not anything that the kernel knows the structure
of, or cares about (like PCI config space, or firmware blobs for
devices.)

Just export the individual fields of this table as individual files
please.

thanks,

greg k-h

  parent reply	other threads:[~2007-09-26 21:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-26 18:46 [PATCH] Add iSCSI iBFT support Konrad Rzeszutek
2007-09-26 19:37 ` roel
2007-09-26 21:10 ` Greg KH [this message]
2007-09-27  0:08   ` Konrad Rzeszutek
2007-09-27  2:04     ` Greg KH
2007-09-26 21:13 ` Randy Dunlap
2007-09-27  0:16   ` Konrad Rzeszutek
2007-09-26 21:29 ` Randy Dunlap
2007-09-27  0:52   ` Konrad Rzeszutek
     [not found]     ` <14e4363b0709261817t5f0b1922m99c24549ce316de8@mail.gmail.com>
2007-09-27  4:00       ` Randy Dunlap
2007-09-27  4:29     ` Randy Dunlap
2007-09-27 17:06     ` H. Peter Anvin
2007-09-27 17:12       ` Peter Jones
2007-09-27 17:18         ` H. Peter Anvin
2007-09-27 17:51           ` Peter Jones
2007-09-27 20:50             ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070926211057.GA3050@kroah.com \
    --to=greg@kroah.com \
    --cc=konrad@darnok.org \
    --cc=konradr@linux.vnet.ibm.com \
    --cc=konradr@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pjones@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox