From: Andrew Morton <akpm@linux-foundation.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: apw@shadowen.org, vagabon.xyz@gmail.com,
linux-kernel@vger.kernel.org, kamalesh@linux.vnet.ibm.com
Subject: Re: 2.6.23-rc8-mm1 -- powerpc link failure
Date: Thu, 27 Sep 2007 15:13:17 -0700 [thread overview]
Message-ID: <20070927151317.67cac358.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0709271408170.7567@jikos.suse.cz>
On Thu, 27 Sep 2007 14:13:21 +0200 (CEST)
Jiri Kosina <jkosina@suse.cz> wrote:
> i386 and x86_64: randomize brk()
>
> ...
>
> --- a/arch/x86_64/ia32/ia32_binfmt.c
> +++ b/arch/x86_64/ia32/ia32_binfmt.c
> @@ -262,6 +262,7 @@ static void elf32_init(struct pt_regs *);
> #define ARCH_HAS_SETUP_ADDITIONAL_PAGES 1
> #define arch_setup_additional_pages syscall32_setup_pages
> extern int syscall32_setup_pages(struct linux_binprm *, int exstack);
> +extern void arch_randomize_brk(void);
>
> #include "../../../fs/binfmt_elf.c"
Is this sinful extern-decl-in-C acually needed?
> index b4fbe47..5a1adf9 100644
> --- a/include/asm-x86_64/elf.h
> +++ b/include/asm-x86_64/elf.h
> @@ -177,4 +177,6 @@ do if (vdso_enabled) { \
>
> #endif
>
> +extern void arch_randomize_brk(void);
> +
> #endif
Because we already have a declaration in the correct place?
next prev parent reply other threads:[~2007-09-27 22:14 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-25 8:46 2.6.23-rc8-mm1 Andrew Morton
2007-09-25 10:39 ` 2.6.23-rc8-mm1 Kamalesh Babulal
2007-09-25 15:46 ` 2.6.23-rc8-mm1 Andrew Morton
2007-09-25 12:19 ` [-mm Patch] fs/udf/balloc.c: mark a variable as uninitialized_var() WANG Cong
2007-09-25 12:52 ` [-mm Patch] drivers/usb/misc/sisusbvga/sisusb.c: kill two unused variables WANG Cong
2007-09-25 12:53 ` 2.6.23-rc8-mm1 - drivers/net/ibm_newemac/mal - broken Kamalesh Babulal
2007-09-25 16:16 ` Andrew Morton
2007-09-25 13:46 ` 2.6.23-rc8-mm1 -- powerpc link failure Andy Whitcroft
2007-09-25 15:23 ` Jiri Kosina
2007-09-27 12:03 ` Andy Whitcroft
2007-09-27 12:13 ` Jiri Kosina
2007-09-27 17:13 ` Andrew Morton
2007-09-27 19:31 ` Sam Ravnborg
2007-09-27 22:13 ` Andrew Morton [this message]
2007-09-27 22:17 ` Jiri Kosina
2007-09-25 17:26 ` 2.6.23-rc8-mm1 Randy Dunlap
2007-09-25 17:39 ` 2.6.23-rc8-mm1 Josef Sipek
2007-09-25 17:45 ` [PATCH 1/1] Unionfs: move poison #define into poison.h Josef 'Jeff' Sipek
2007-09-26 1:02 ` Josef 'Jeff' Sipek
2007-09-25 19:02 ` 2.6.23-rc8-mm1: unscrew UFS Alexey Dobriyan
2007-09-25 20:00 ` 2.6.23-rc8-mm1 - powerpc memory hotplug link failure Kamalesh Babulal
2007-09-25 22:01 ` Badari Pulavarty
2007-09-26 8:18 ` Kamalesh Babulal
2007-09-26 1:32 ` KAMEZAWA Hiroyuki
2007-09-26 1:48 ` KAMEZAWA Hiroyuki
2007-09-26 8:19 ` Kamalesh Babulal
2007-09-25 20:56 ` 2.6.23-rc8-mm1: drivers/kvm/ioapic.o build failure Mariusz Kozlowski
2007-09-26 9:00 ` [kvm-devel] " Avi Kivity
2007-09-26 9:14 ` Andrew Morton
2007-09-26 9:18 ` Avi Kivity
2007-09-25 22:05 ` 2.6.23-rc8-mm1 Badari Pulavarty
2007-09-26 12:28 ` 2.6.23-rc8-mm1 Andy Whitcroft
2007-09-25 22:23 ` 2.6.23-rc8-mm1 : wgt634u.c trem
2007-09-26 7:51 ` black screen after kill X [Was: 2.6.23-rc8-mm1] Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070927151317.67cac358.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=jkosina@suse.cz \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vagabon.xyz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox