From: Christoph Hellwig <hch@infradead.org>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Laurent Riffard <laurent.riffard@free.fr>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
reiserfs-devel@vger.kernel.org
Subject: Re: [RFC][PATCH] make reiserfs stop using 'struct file' for internal xattr operations
Date: Thu, 27 Sep 2007 22:04:23 +0100 [thread overview]
Message-ID: <20070927210423.GA6117@infradead.org> (raw)
In-Reply-To: <1190926419.7344.27.camel@localhost>
On Thu, Sep 27, 2007 at 01:53:39PM -0700, Dave Hansen wrote:
> -int reiserfs_commit_write(struct file *f, struct page *page,
> - unsigned from, unsigned to);
> -int reiserfs_prepare_write(struct file *f, struct page *page,
> - unsigned from, unsigned to);
> +int reiserfs_commit_write(struct page *page, unsigned from, unsigned to);
> +int reiserfs_prepare_write(struct page *page, unsigned from, unsigned to);
I doubt this will work. These are also used for the ->prepare_write
and ->commit_write aops, and the method signature definitively wants
a file there, even if it's zero..
next prev parent reply other threads:[~2007-09-27 21:04 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-27 9:22 2.6.23-rc8-mm2 Andrew Morton
2007-09-27 10:52 ` 2.6.23-rc8-mm2 - drivers/net/ibm_newemac/mal - broken Kamalesh Babulal
2007-09-27 15:19 ` 2.6.23-rc8-mm2: problems on HP nx6325 Rafael J. Wysocki
2007-09-27 15:59 ` Rafael J. Wysocki
2007-09-27 15:49 ` Thomas Gleixner
2007-09-28 21:31 ` Rafael J. Wysocki
2007-09-27 16:53 ` Sam Ravnborg
2007-09-27 17:33 ` Randy Dunlap
2007-09-27 19:19 ` Sam Ravnborg
2007-09-27 19:48 ` Rafael J. Wysocki
2007-09-27 19:37 ` Randy Dunlap
2007-09-27 20:01 ` Rafael J. Wysocki
2007-09-27 19:18 ` 2.6.23-rc8-mm2: BUG near reiserfs_xattr_set Laurent Riffard
2007-09-27 19:48 ` Andrew Morton
2007-09-27 20:05 ` Dave Hansen
2007-09-27 20:26 ` Christoph Hellwig
2007-09-27 20:53 ` [RFC][PATCH] make reiserfs stop using 'struct file' for internal xattr operations Dave Hansen
2007-09-27 21:04 ` Christoph Hellwig [this message]
2007-09-27 21:27 ` Dave Hansen
2007-09-27 21:51 ` Andrew Morton
2007-09-27 21:54 ` Andrew Morton
2007-09-27 22:02 ` Peter Zijlstra
2007-09-28 7:16 ` Christoph Hellwig
2007-09-28 7:29 ` [RFC][PATCH] stop abusing filp_open in reiserfs journal code Christoph Hellwig
[not found] ` <20070928024054.GA14457@mail.ustc.edu.cn>
2007-09-28 2:40 ` WARNING: at arch/x86_64/kernel/smp.c:397 smp_call_function_mask() Fengguang Wu
2007-09-28 8:52 ` Laurent Vivier
2007-09-28 9:09 ` Andrew Morton
2007-09-28 9:18 ` Laurent Vivier
2007-09-28 9:34 ` Andrew Morton
2007-09-28 12:07 ` Laurent Vivier
[not found] ` <20070929065908.GA19615@mail.ustc.edu.cn>
2007-09-29 6:59 ` Fengguang Wu
[not found] ` <20070929081524.GA32760@mail.ustc.edu.cn>
2007-09-29 8:15 ` Fengguang Wu
[not found] ` <20071002091133.GA31284@mail.ustc.edu.cn>
2007-10-02 9:11 ` [PATCH][RESEND] call free_init_pages() with irqs enabled in alternative_instructions() Fengguang Wu
2007-09-28 15:42 ` 2.6.23-rc8-mm2 - tcp_fastretrans_alert() WARNING Cedric Le Goater
2007-09-28 19:10 ` Ilpo Järvinen
2007-09-29 12:44 ` Ilpo Järvinen
2007-09-29 14:55 ` Cedric Le Goater
2007-09-29 20:49 ` Ilpo Järvinen
2007-10-01 9:26 ` Cedric Le Goater
2007-10-02 10:26 ` Ilpo Järvinen
2007-10-02 20:06 ` Ilpo Järvinen
2007-10-02 21:48 ` Ilpo Järvinen
2007-09-28 16:30 ` /proc/net/ bad hard links count [Was: 2.6.23-rc8-mm2] Jiri Slaby
2007-09-28 17:03 ` Eric W. Biederman
2007-09-29 9:37 ` 2.6.23-rc8-mm2 Dave Young
2007-09-29 15:19 ` 2.6.23-rc8-mm2 Greg KH
2007-09-30 1:29 ` 2.6.23-rc8-mm2 Dave Young
2007-09-30 5:18 ` 2.6.23-rc8-mm2 thunder7
2007-10-08 6:43 ` 2.6.23-rc8-mm2 Dave Young
2007-09-30 2:26 ` 2.6.23-rc8-mm2 Valdis.Kletnieks
2007-09-30 8:50 ` 2.6.23-rc8-mm2 Andrew Morton
2007-09-30 20:01 ` 2.6.23-rc8-mm2 Rafael J. Wysocki
2007-10-01 17:12 ` 2.6.23-rc8-mm2 Valdis.Kletnieks
2007-10-01 16:12 ` 2.6.23-rc8-mm2 Valdis.Kletnieks
2007-09-30 4:10 ` 2.6.23-rc8-mm2 - PowerPC link failure at arch/powerpc/kernel/head_64.o Kamalesh Babulal
2007-09-30 9:37 ` Kamalesh Babulal
2007-10-09 17:49 ` 2.6.23-rc8-mm2 Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070927210423.GA6117@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=haveblue@us.ibm.com \
--cc=laurent.riffard@free.fr \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox