public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Jordan Crouse" <jordan.crouse@amd.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: jkeating@redhat.com, "Joerg Pommnitz" <pommnitz@yahoo.com>,
	"Chuck Ebbert" <cebbert@redhat.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Andi Kleen" <ak@suse.de>
Subject: Re: More E820 brokenness
Date: Thu, 27 Sep 2007 16:33:36 -0600	[thread overview]
Message-ID: <20070927223336.GB4755@cosmic.amd.com> (raw)
In-Reply-To: <46FC2BFD.6070200@zytor.com>

On 27/09/07 15:17 -0700, H. Peter Anvin wrote:
> As luck would have it, it's not just an obscure Geode system which has a
> broken E820 implementation.  Today I received a bug report about a Dell
> system (XPS M1330) with broken E820.
> 
> Unfortunately, the workaround for the Geode breaks this system, because
> x86-64 doesn't fall back to the e801/88 information like the i386 kernel
> does.
> 
> I wonder if the relevant people could test out this patch to see how it
> works on their respective system.  This patch reverts to 2.6.23-rc8
> behaviour of simply truncating the map, but still makes e801/88 info
> available to the kernel; this hopefully should match 2.6.22 behaviour.

Breaks on the Geode - original behavior.

I think that having boot_prams.e820_entries != 0 makes the kernel
assume the e820 data is correct.

> I want to emphasize that this is seriously broken.  Using a partial e820
> map could have disastrous results, since the kernel will have partial
> memory map information and not know about reserved areas, etc.  Part of
> me feels that the right thing to do is what the current git kernel does
> -- either fall back to e801, or stop and error.

I'm inclined to agree.  

Jordan



  reply	other threads:[~2007-09-27 22:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-27 22:17 More E820 brokenness H. Peter Anvin
2007-09-27 22:33 ` Jordan Crouse [this message]
2007-09-27 22:47   ` H. Peter Anvin
2007-09-27 23:15     ` Jordan Crouse
2007-09-27 23:22       ` H. Peter Anvin
2007-09-27 23:27       ` H. Peter Anvin
2007-09-27 23:34         ` Jordan Crouse
2007-09-27 23:36           ` H. Peter Anvin
2007-09-27 23:54             ` Jordan Crouse
2007-09-28  0:12               ` H. Peter Anvin
2007-09-28 13:05                 ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070927223336.GB4755@cosmic.amd.com \
    --to=jordan.crouse@amd.com \
    --cc=ak@suse.de \
    --cc=cebbert@redhat.com \
    --cc=hpa@zytor.com \
    --cc=jkeating@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pommnitz@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox