From: Paul Mundt <lethal@linux-sh.org>
To: Mark Gross <mgross@linux.intel.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
linux-pm <linux-pm@lists.linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] QoS params patch update.
Date: Fri, 28 Sep 2007 09:08:47 +0900 [thread overview]
Message-ID: <20070928000847.GA30814@linux-sh.org> (raw)
In-Reply-To: <20070927201739.GA2831@linux.intel.com>
On Thu, Sep 27, 2007 at 01:17:39PM -0700, Mark Gross wrote:
> Updated qos PM parameter patch:
> Note: the replacing of latency.c with this is a separate patch.
>
> this patch attempts to address the issues raised so far.
>
[snip]
> +static int register_new_qos_misc(struct qos_object *qos)
> +{
> + int ret;
> +
> + qos->qos_power_miscdev.minor = MISC_DYNAMIC_MINOR;
> + qos->qos_power_miscdev.name = qos->name;
> + qos->qos_power_miscdev.fops = &qos_power_fops;
> +
> + ret = misc_register(&qos->qos_power_miscdev);
> +
> + return ret;
> +}
> +
Minor nit, ret is a pointless variable here, you can just return
misc_register directly.
Other than that, this looks much better!
next prev parent reply other threads:[~2007-09-28 0:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-26 22:37 [RFC] QoS power Management enabling patch set Mark Gross
2007-09-26 22:40 ` [RFC] QoS params patch Mark Gross
2007-09-26 23:41 ` Randy Dunlap
2007-09-27 0:40 ` Mark Gross
2007-09-27 2:53 ` Valdis.Kletnieks
2007-09-27 3:18 ` Paul Mundt
2007-09-27 15:17 ` Mark Gross
2007-09-27 15:36 ` Mark Gross
2007-09-27 13:00 ` roel
2007-09-27 2:24 ` Paul Mundt
2007-09-27 4:05 ` Randy Dunlap
2007-09-27 15:37 ` Mark Gross
2007-09-27 20:17 ` [RFC] QoS params patch update Mark Gross
2007-09-28 0:08 ` Paul Mundt [this message]
2007-09-27 16:21 ` [RFC] QoS params patch Mark Gross
2007-09-28 6:25 ` Andrew Morton
2007-09-28 6:41 ` Paul Mundt
2007-09-28 17:22 ` Mark Gross
2007-09-28 17:19 ` Mark Gross
2007-09-28 18:51 ` Andrew Morton
2007-10-01 16:11 ` Mark Gross
2007-09-26 22:42 ` [RFC] QoS power Management enabling patch set Mark Gross
2007-09-26 22:45 ` [RFC] QoS power example / hack Mark Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070928000847.GA30814@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mgross@linux.intel.com \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox