* [PATCH 1/4] dma: add dma_flags_set_dmaflush() to dma interface
@ 2007-09-26 0:00 akepner
2007-09-26 5:13 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: akepner @ 2007-09-26 0:00 UTC (permalink / raw)
To: Grant Grundler, Jesse Barnes, Jes Sorensen, Randy Dunlap,
David Miller, Roland Dreier
Cc: linux-kernel
Introduce the dma_flags_set_dmaflush() interface and give it
a default no-op implementation.
Signed-off-by: Arthur Kepner <akepner@sgi.com>
--
dma-mapping.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
index 2dc21cb..a0f27b9 100644
--- a/include/linux/dma-mapping.h
+++ b/include/linux/dma-mapping.h
@@ -99,4 +99,11 @@ static inline void dmam_release_declared_memory(struct device *dev)
}
#endif /* ARCH_HAS_DMA_DECLARE_COHERENT_MEMORY */
+#ifndef ARCH_CAN_REORDER_DMA
+static inline int
+dma_flags_set_dmaflush(int dir) {
+ return (dir);
+}
+#endif /* ARCH_CAN_REORDER_DMA */
+
#endif
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/4] dma: add dma_flags_set_dmaflush() to dma interface
2007-09-26 0:00 [PATCH 1/4] dma: add dma_flags_set_dmaflush() to dma interface akepner
@ 2007-09-26 5:13 ` Randy Dunlap
2007-09-28 0:20 ` akepner
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2007-09-26 5:13 UTC (permalink / raw)
To: akepner
Cc: Grant Grundler, Jesse Barnes, Jes Sorensen, David Miller,
Roland Dreier, linux-kernel, jejb
On Tue, 25 Sep 2007 17:00:57 -0700 akepner@sgi.com wrote:
[adding James Bottomley to cc: since I think he's interested in
all of these patches]
> Introduce the dma_flags_set_dmaflush() interface and give it
> a default no-op implementation.
>
> Signed-off-by: Arthur Kepner <akepner@sgi.com>
> --
>
> dma-mapping.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
> index 2dc21cb..a0f27b9 100644
> --- a/include/linux/dma-mapping.h
> +++ b/include/linux/dma-mapping.h
> @@ -99,4 +99,11 @@ static inline void dmam_release_declared_memory(struct device *dev)
> }
> #endif /* ARCH_HAS_DMA_DECLARE_COHERENT_MEMORY */
>
> +#ifndef ARCH_CAN_REORDER_DMA
> +static inline int
> +dma_flags_set_dmaflush(int dir) {
> + return (dir);
> +}
> +#endif /* ARCH_CAN_REORDER_DMA */
> +
> #endif
1. Function signature should be on one line if possible (and it is).
Aw crud, I looked at dma-mapping.h and it uses this format sometimes.
Well, it's undesirable, so please don't propagate it.
2. No parens on return: it's not a function.
static inline int dma_flags_set_dmaflush(int dir)
{
return dir;
}
Similar comments for patch 2/4: sn-ia64.
---
~Randy
Phaedrus says that Quality is about caring.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/4] dma: add dma_flags_set_dmaflush() to dma interface
2007-09-26 5:13 ` Randy Dunlap
@ 2007-09-28 0:20 ` akepner
0 siblings, 0 replies; 3+ messages in thread
From: akepner @ 2007-09-28 0:20 UTC (permalink / raw)
To: Randy Dunlap
Cc: Grant Grundler, Jesse Barnes, Jes Sorensen, David Miller,
Roland Dreier, linux-kernel, jejb
On Tue, Sep 25, 2007 at 10:13:33PM -0700, Randy Dunlap wrote:
> On Tue, 25 Sep 2007 17:00:57 -0700 akepner@sgi.com wrote:
> ......
> 1. Function signature should be on one line if possible (and it is).
> Aw crud, I looked at dma-mapping.h and it uses this format sometimes.
> Well, it's undesirable, so please don't propagate it.
>
> 2. No parens on return: it's not a function.
>
> static inline int dma_flags_set_dmaflush(int dir)
> {
> return dir;
> }
>
>
> Similar comments for patch 2/4: sn-ia64.
>
Both fixed in next version. Thanks, Randy.
--
Arthur
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-09-28 0:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-26 0:00 [PATCH 1/4] dma: add dma_flags_set_dmaflush() to dma interface akepner
2007-09-26 5:13 ` Randy Dunlap
2007-09-28 0:20 ` akepner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox