From: Jeff Dike <jdike@addtoit.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [PATCH] UML - Correctly handle skb allocation failures
Date: Thu, 27 Sep 2007 21:21:32 -0400 [thread overview]
Message-ID: <20070928012132.GA10302@c2.user-mode-linux.org> (raw)
In-Reply-To: <20070927165340.fd5dc2d0.akpm@linux-foundation.org>
On Thu, Sep 27, 2007 at 04:53:40PM -0700, Andrew Morton wrote:
> Still wanna know why it is safe for uml_net_rx to be playing with
> drop_skb when update_drop_skb() could be concurrently reallocating
> and freeing it.
Ah, yes, I missed that point in the horror of my botch last night.
I'll add irqsave/irqrestore to the locking - keep this patch, and I'll
send in a fix.
Jeff
--
Work email - jdike at linux dot intel dot com
prev parent reply other threads:[~2007-09-28 1:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-27 17:01 [PATCH] UML - Correctly handle skb allocation failures Jeff Dike
2007-09-27 23:53 ` Andrew Morton
2007-09-28 1:21 ` Jeff Dike [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070928012132.GA10302@c2.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox