From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, roel <12o3l@tiscali.nl>,
lkml <linux-kernel@vger.kernel.org>,
Andy Whitcroft <apw@shadowen.org>,
Randy Dunlap <rdunlap@xenotime.net>
Subject: Re: [PATCH] spin_lock_unlocked cleanups
Date: Fri, 28 Sep 2007 10:30:37 +0200 [thread overview]
Message-ID: <20070928083037.GA18295@elte.hu> (raw)
In-Reply-To: <20070928012656.0bae3991.akpm@linux-foundation.org>
* Andrew Morton <akpm@linux-foundation.org> wrote:
> On Fri, 28 Sep 2007 10:17:30 +0200 Thomas Gleixner <tglx@linutronix.de> wrote:
>
> > can we please add this to checkpatch.pl ?
> >
> > > -spinlock_t bpci_lock = SPIN_LOCK_UNLOCKED;
> > > +DEFINE_SPINLOCK(bpci_lock);
>
> That check is already in checkpatch. Problem is that hardly anyone
> runs the thing.
i automatically run it for every patch i submit or push out via git.
> I think we're ready to wire checkpatch up to a email robot which
> monitors the mailing lists and sends people nastygrams. I bet that'll
> be popular ;)
heh ;-) It could be automated for patches that are sent out with a
Signed-off-by [or a Reviewed-by] line. If you send a SoB patch that is
broken, prepare to get a nastygram. (Initially i'd suggest the nastygram
to Cc: to a different email list, not lkml.)
Ingo
next prev parent reply other threads:[~2007-09-28 8:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-27 21:36 [PATCH] spin_lock_unlocked cleanups roel
2007-09-28 8:17 ` Thomas Gleixner
2007-09-28 8:26 ` Andrew Morton
2007-09-28 8:30 ` Ingo Molnar [this message]
2007-09-28 8:55 ` Andrew Morton
2007-09-28 8:32 ` Thomas Gleixner
2007-09-28 8:56 ` Andy Whitcroft
2007-09-28 9:06 ` Thomas Gleixner
2007-09-28 21:15 ` Sean
2007-09-28 8:53 ` Andy Whitcroft
2007-09-28 9:05 ` Andrew Morton
2007-09-28 17:31 ` Mark Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070928083037.GA18295@elte.hu \
--to=mingo@elte.hu \
--cc=12o3l@tiscali.nl \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox