public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Landley <rob@landley.net>
To: "Vegard Nossum" <vegard.nossum@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"Kyle Moffett" <mrmacman_g4@mac.com>,
	"Michael Holzheu" <holzheu@linux.vnet.ibm.com>,
	"Joe Perches" <joe@perches.com>,
	"Dick Streefland" <dick.streefland@altium.nl>,
	"Geert Uytterhoeven" <Geert.Uytterhoeven@sonycom.com>,
	"Jesse Barnes" <jesse.barnes@intel.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Jan Engelhardt" <jengelh@computergmbh.de>,
	"Emil Medve" <Emilian.Medve@freescale.com>,
	"Stephen Hemminger" <shemminger@linux-foundation.org>,
	"linux@horizon.com" <linux@horizon.com>
Subject: Re: [RFC] New kernel-message logging API (take 2)
Date: Fri, 28 Sep 2007 11:30:25 -0500	[thread overview]
Message-ID: <200709281130.26124.rob@landley.net> (raw)
In-Reply-To: <19f34abd0709280511h3f31681bh54c6af287a48c02f@mail.gmail.com>

On Friday 28 September 2007 7:11:03 am Vegard Nossum wrote:
> wrong. We can, however, use KBUILD_MODNAME as a default value for
> KPRINT_DRIVER, like:
> static const char *KPRINT_DRIVER = KBUILD_MODNAME;
> which would pre-process to something like:
> static const char *KPRINT_DRIVER = "bcm43xx";

Which has been known to result in the string getting written out to the .o 
file even if it's never used, just in case something tries to take its 
address.  This is not the same as a #define.

> This value can still be overridden using #define KPRINT_DRIVER "new
> name".

Not with -D on the command line though.  Your #define would have to come after 
the declaration or else the declaration turns into 'char *"fred" = "george";' 
and you have a syntax error.  Again, not synonymous with a #define...

Rob
-- 
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

  parent reply	other threads:[~2007-09-28 16:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-27 21:18 [RFC] New kernel-message logging API (take 2) Vegard Nossum
2007-09-28  1:38 ` linux
2007-09-28  7:31 ` Geert Uytterhoeven
2007-09-28  7:44   ` Kyle Moffett
2007-09-28 11:49     ` Vegard Nossum
2007-09-28 11:46   ` Vegard Nossum
2007-09-28  8:22 ` Dick Streefland
2007-09-28  9:45 ` Jan Engelhardt
2007-09-28 11:59   ` Vegard Nossum
2007-09-28 12:11 ` Vegard Nossum
2007-09-28 13:30   ` Miguel Ojeda
2007-09-28 13:55     ` Vegard Nossum
2007-09-28 14:00       ` Miguel Ojeda
2007-09-28 16:30   ` Rob Landley [this message]
2007-09-28 16:41     ` Vegard Nossum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200709281130.26124.rob@landley.net \
    --to=rob@landley.net \
    --cc=Emilian.Medve@freescale.com \
    --cc=Geert.Uytterhoeven@sonycom.com \
    --cc=arnd@arndb.de \
    --cc=dick.streefland@altium.nl \
    --cc=holzheu@linux.vnet.ibm.com \
    --cc=jengelh@computergmbh.de \
    --cc=jesse.barnes@intel.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@horizon.com \
    --cc=mrmacman_g4@mac.com \
    --cc=shemminger@linux-foundation.org \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox