From: Sam Ravnborg <sam@ravnborg.org>
To: Milton Miller <miltonm@bga.com>
Cc: Kai Germaschewski <kai@germaschewski.name>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH Kbuild] Call only one make with all targets for O=
Date: Fri, 28 Sep 2007 21:24:34 +0200 [thread overview]
Message-ID: <20070928192434.GA10769@uranus.ravnborg.org> (raw)
In-Reply-To: <kbuild-8-00.miltonm@bga.com>
On Fri, Sep 21, 2007 at 06:09:02PM -0500, Milton Miller wrote:
> Change the invocations of make in the output directory Makefile and the
> main Makefile for seperate object trees to pass all goals to one $(MAKE)
> via a new phony target "sub-make" and the existing target _all.
>
> When compiling with seperate object directories, a seperate make is called
> in the context of another directory (from the output directory the main
> Makefile is called, the Makefile is then restarted with current directory
> set to the object tree). Before this patch, when multiple make command
> goals are specified, each target results in a seperate make invocation.
> With make -j, these invocations may run in parallel, resulting in multiple
> commands running in the same directory clobbering each others results.
>
> I did not try to address make -j for mixed dot-config and no-dot-config
> targets. Because the order does matter, a solution was not obvious.
> Perhaps a simple check for MAKEFLAGS having -j and refusing to run would
> be approprate.
Applied to kbuild.git.
This was a nice one to get ruined out.
Thanks Milton,
Sam
prev parent reply other threads:[~2007-09-28 19:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-21 23:09 [PATCH Kbuild] Call only one make with all targets for O= Milton Miller
2007-09-28 19:24 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070928192434.GA10769@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=kai@germaschewski.name \
--cc=linux-kernel@vger.kernel.org \
--cc=miltonm@bga.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox