From: Jean Delvare <khali@linux-fr.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Brownell <david-b@pacbell.net>
Subject: [PATCH] CodingStyle: Printing numbers in parentheses is fine
Date: Sat, 29 Sep 2007 12:25:30 +0200 [thread overview]
Message-ID: <20070929122530.5c45f743@hyperion.delvare> (raw)
Remove a not particularly relevant rule from CodingStyle.
Sometimes, printing numbers in parentheses doesn't add value, but in
some (most?) cases it makes the message easier to read. As a matter of
fact, this practice is widely used in the kernel:
linux-2.6.23-rc8$ quilt grep -I '(%l*[du])' | wc -l
3166
linux-2.6.23-rc8$
Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
Documentation/CodingStyle | 2 --
1 file changed, 2 deletions(-)
--- linux-2.6.23-rc8.orig/Documentation/CodingStyle 2007-07-23 16:44:32.000000000 +0200
+++ linux-2.6.23-rc8/Documentation/CodingStyle 2007-09-28 23:53:23.000000000 +0200
@@ -638,8 +638,6 @@ concise, clear, and unambiguous.
Kernel messages do not have to be terminated with a period.
-Printing numbers in parentheses (%d) adds no value and should be avoided.
-
There are a number of driver model diagnostic macros in <linux/device.h>
which you should use to make sure messages are matched to the right device
and driver, and are tagged with the right level: dev_err(), dev_warn(),
--
Jean Delvare
next reply other threads:[~2007-09-29 10:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-29 10:25 Jean Delvare [this message]
2007-09-29 10:51 ` [PATCH] CodingStyle: Printing numbers in parentheses is fine Andrew Morton
2007-09-29 17:19 ` David Brownell
2007-09-29 18:29 ` Randy Dunlap
2007-09-29 18:53 ` David Brownell
2007-09-29 20:13 ` Randy Dunlap
2007-09-29 22:30 ` David Brownell
2007-09-29 22:51 ` Randy Dunlap
2007-09-29 22:55 ` Måns Rullgård
2007-09-30 10:28 ` Jean Delvare
2007-09-30 2:18 ` Valdis.Kletnieks
2007-09-30 10:11 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070929122530.5c45f743@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox