From: "J. Bruce Fields" <bfields@fieldses.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Erez Zadok <ezk@cs.sunysb.edu>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 0/3 coding standards documentation/code updates
Date: Sat, 29 Sep 2007 15:56:38 -0400 [thread overview]
Message-ID: <20070929195638.GA12011@fieldses.org> (raw)
In-Reply-To: <alpine.LFD.0.999.0709291116180.3579@woody.linux-foundation.org>
On Sat, Sep 29, 2007 at 11:18:05AM -0700, Linus Torvalds wrote:
> I'm not very happy with this.
>
> "CodingStyle" should be about the big issues, not about details. Yes,
> we've messed that up over the years, but let's not continue that.
>
> In other words, I'd suggest *removing* lines from CodingStyle, not adding
> them. The file has already gone from a "good general principles" to "lots
> of stupid details". Let's not make it worse.
It'd be nice to split the current CodingStyle into two documents:
- A shorter CodingStyle that gives the spirit of the style
(short functions, minimal nesting, logic as straightforward as
possible, etc.), and addresses the most commonly repeated
mistakes, without so much detail that people's eyes glaze
over. You want to be able to recommend it to your students
(or whoever) in reasonable confidence that they'll actually
read it and have fun (leave the jokes in!). Currently I'm
suspicious that it's becoming something that everybody
recommends but noone bothers to sit down and read anymore
unless they're working on it.
- A CodingStyleReference that's just a long dry list of rules,
organized to make it easy to look up an individual rule when
needed. That'd also take the pressure of CodingStyle to
accept every new detail.
It'd be a start just to revert CodingStyle to its original content and
move the rest to CodingStyleReference. But someone would want to skim
through the CodingStyle history for any legimate corrections that we
want to keep.
--b.
next prev parent reply other threads:[~2007-09-29 19:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-28 21:31 [PATCH] 0/3 coding standards documentation/code updates Erez Zadok
2007-09-28 21:32 ` [PATCH 1/3] CodingStyle updates Erez Zadok
2007-09-28 21:46 ` Randy Dunlap
2007-09-29 14:43 ` Shawn Bohrer
2007-09-29 15:59 ` Scott Preece
2007-09-29 18:01 ` Randy Dunlap
2007-09-29 18:29 ` Sam Ravnborg
2007-09-29 20:21 ` [OT] kbuild syntax extension for ccflags and asflags (was: [PATCH 1/3] CodingStyle updates) Ingo Oeser
2007-09-29 20:24 ` Sam Ravnborg
2007-09-28 21:32 ` [PATCH 2/3] Update usage string for checkpatch.pl Erez Zadok
2007-09-28 21:32 ` [PATCH 3/3] New script to check coding-style compliance on multiple regular files Erez Zadok
2007-09-29 10:10 ` Sam Ravnborg
2007-09-29 18:18 ` [PATCH] 0/3 coding standards documentation/code updates Linus Torvalds
2007-09-29 19:56 ` J. Bruce Fields [this message]
2007-09-29 20:14 ` Randy Dunlap
2007-09-30 2:06 ` Theodore Tso
2007-09-30 3:28 ` Erez Zadok
2007-09-29 21:56 ` Robert P. J. Day
2007-09-30 0:23 ` Erez Zadok
2007-09-30 0:49 ` Linus Torvalds
2007-09-30 4:01 ` Erez Zadok
2007-09-30 17:40 ` Mark Lord
2007-09-30 17:59 ` Randy Dunlap
2007-09-30 2:24 ` Valdis.Kletnieks
2007-09-30 3:00 ` Linus Torvalds
2007-09-30 3:29 ` Valdis.Kletnieks
2007-09-30 3:35 ` Linus Torvalds
2007-09-30 17:57 ` Theodore Tso
2007-09-30 3:27 ` Al Viro
2007-09-30 3:39 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070929195638.GA12011@fieldses.org \
--to=bfields@fieldses.org \
--cc=akpm@linux-foundation.org \
--cc=ezk@cs.sunysb.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox