From: Nick Piggin <npiggin@suse.de>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
David Howells <dhowells@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andi Kleen <ak@suse.de>
Subject: Re: [rfc][patch] i386: remove comment about barriers
Date: Sun, 30 Sep 2007 13:58:55 +0200 [thread overview]
Message-ID: <20070930115854.GA7697@wotan.suse.de> (raw)
In-Reply-To: <20070930031647.GG9119@linux.vnet.ibm.com>
On Sat, Sep 29, 2007 at 08:16:47PM -0700, Paul E. McKenney wrote:
> On Sat, Sep 29, 2007 at 03:28:48PM +0200, Nick Piggin wrote:
>
> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>
Thanks v much for confirming, everyone.
> > Signed-off-by: Nick Piggin <npiggin@suse.de>
> >
> > ---
> > Index: linux-2.6/include/asm-i386/system.h
> > ===================================================================
> > --- linux-2.6.orig/include/asm-i386/system.h
> > +++ linux-2.6/include/asm-i386/system.h
> > @@ -214,11 +214,6 @@ static inline unsigned long get_limit(un
> > */
> >
> >
> > -/*
> > - * Actually only lfence would be needed for mb() because all stores done
> > - * by the kernel should be already ordered. But keep a full barrier for now.
> > - */
> > -
> > #define mb() alternative("lock; addl $0,0(%%esp)", "mfence", X86_FEATURE_XMM2)
> > #define rmb() alternative("lock; addl $0,0(%%esp)", "lfence", X86_FEATURE_XMM2)
> >
next prev parent reply other threads:[~2007-09-30 11:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-29 13:28 [rfc][patch] i386: remove comment about barriers Nick Piggin
2007-09-29 16:11 ` Linus Torvalds
2007-09-29 19:12 ` Davide Libenzi
2007-09-30 12:05 ` Nick Piggin
2007-09-30 3:16 ` Paul E. McKenney
2007-09-30 11:58 ` Nick Piggin [this message]
2007-09-30 15:09 ` Andi Kleen
2007-10-01 13:14 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070930115854.GA7697@wotan.suse.de \
--to=npiggin@suse.de \
--cc=ak@suse.de \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox