The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Jan Luebbe <jluebbe@lasnet.de>
Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Subject: Re: [PATCH] fix console change race exposed by CFS
Date: Sun, 30 Sep 2007 17:53:30 +0200	[thread overview]
Message-ID: <20070930155328.GE24077@elte.hu> (raw)
In-Reply-To: <1191141065.10375.9.camel@polaris>


* Jan Luebbe <jluebbe@lasnet.de> wrote:

> I'm currenly porting the OpenMoko patchset to 2.6.23-rc8. We are using 
> psplash and kdrive. When booting, I got an error from psplash about 
> being unable to switch consoles. Strangely, it was possible to start 
> kdrive manually. So i set up qemu for kernel debugging, set some 
> interesting breakpoints and then saw that it was scheduling away 
> directly after the kill_pid. Then it was quite obvious.
> 
> It was triggering every time, on the device and in qemu identically. 
> Most people testing the RCs probably don't run psplash (or any other 
> program which sets vt_mode.mode to VT_PROCESS), so it wasn't noticed 
> earlier.

thx for the description. I did some searching on google.com/codesearch, 
and here are some other console apps that make active use of VT_PROCESS:

   1diskxwin-2.0.0/X11/programs/Xserver/hw/kdrive/linux/linux.c
   usr/include/dev/wscons/wsdisplay_compat_usl.c
   busybox-1.01/loginutils/vlock.c
   allegro-4.2.2/src/linux/vtswitch.c
   tvision/classes/linux/linuxkey.cc
   xc/programs/Xserver/hw/xfree86/os-support/pmax/pmax_init.c
   aalib-1.4.0/src/aalinuxkbd.c
   qt-embedded-opensource-4.0.0-b2/src/gui/embedded/qkbdtty_qws.cpp
   mc-4.5.55/src/cons.handler.c
   psplash-0.1/psplash-console.c
   quakeforge-0.5.5/libs/video/targets/vid_fbdev.c

just in case someone has a regression with any of them, on an older 
kernel. To me it appears X should have triggered this too. Perhaps 
people dont switch between VGA and X all that frequently anymore ...

	Ingo

      reply	other threads:[~2007-09-30 15:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-29 16:47 [PATCH] fix console change race exposed by CFS Jan Luebbe
2007-09-30  7:20 ` Ingo Molnar
2007-09-30  8:31   ` Jan Luebbe
2007-09-30 15:53     ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070930155328.GE24077@elte.hu \
    --to=mingo@elte.hu \
    --cc=jluebbe@lasnet.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox