Re: [PATCH] 0/3 coding standards documentation/code updates

Erez Zadok
2007-09-30T00:24:17Z

In message <alpine.LFD.0.999.0709291116180.3579@woody.linux-foundation.org>, Linus Torvalds writes:
>
>
> On Fri, 28 Sep 2007, Erez Zadok wrote:
> >
> > Documentation/CodingStyle | 88 +++++++++++++++++++++++++++++++++++++-
>
> I'm not very happy with this.
>
> "CodingStyle" should be about the big issues, not about details. Yes,
> we've messed that up over the years, but let's not continue that.
>
> In other words, I'd suggest *removing* lines from CodingStyle, not adding
> them. The file has already gone from a "good general principles" to "lots
> of stupid details". Let's not make it worse.
>
> Linus

There's a lot of good value in having all those details, as it helps people
standardize on more common practices, including details. I think removing
all those details may only increase the amount-of less-accepted code to be
posted, resulting in more lkml people having to repeat themselves on what
not to do. Only now, they won't be able to point people to the CodingStyle
file for what they should do right.

Would you prefer if CodingStyle was reorganized or even split into (1)
general principles and (2) details? Perhaps we need a CodingStylePrinciples
and a CodingStyleDetails?

IOW, where should that very useful info live?

Erez.