Re: [patch] printk: add KERN_CONT annotation

Andrew Morton
2007-10-04T20:44:32Z

On Tue, 2 Oct 2007 07:18:52 +0200
Ingo Molnar <mingo@elte.hu> wrote:

>
> printk: add the KERN_CONT annotation (which is empty string but via
> which checkpatch.pl can notice that the lacking KERN_ level is fine).
> This useful for multiple calls of hand-crafted printk output done by
> early debug code or similar.
>

I like it. Sort of self-documenting notation.

>
> Index: linux/include/linux/kernel.h
> ===================================================================
> --- linux.orig/include/linux/kernel.h
> +++ linux/include/linux/kernel.h
> @@ -61,6 +61,13 @@ extern const char linux_proc_banner[];
> #define KERN_INFO "<6>" /* informational */
> #define KERN_DEBUG "<7>" /* debug-level messages */
>
> +/*
> + * Annotation for a "continued" line of log printout (only done after a
> + * line that had no enclosing \n). Only to be used by core/arch code
> + * during early bootup (a continued line is not SMP-safe otherwise).
> + */
> +#define KERN_CONT ""
> +
> extern int console_printk[];
>
> #define console_loglevel (console_printk[0])
> Index: linux/kernel/sched.c

I get rejects from the sched.c hunk and that's your stuff anwyay, so I
dropped that bit.