From: Greg KH <gregkh@suse.de>
To: JoonwooPark <joonwpark81@gmail.com>
Cc: linux-kernel@vger.kernel.org, kristen.c.accardi@intel.com
Subject: Re: [PATCH] PCI hotplug : Switch to pci_get_bus_and_slot instead of deprecated pci_find_slot.
Date: Sun, 30 Sep 2007 23:10:25 -0700 [thread overview]
Message-ID: <20071001061025.GA11573@suse.de> (raw)
In-Reply-To: <1191208147.6123.11.camel@joonwpark-desktop>
On Mon, Oct 01, 2007 at 12:09:07PM +0900, JoonwooPark wrote:
> This patch fixes these warnings:
>
> drivers/pci/hotplug/cpqphp_pci.c: In function ???cpqhp_configure_device???:
> drivers/pci/hotplug/cpqphp_pci.c:92: warning: ???pci_find_slot??? is deprecated (declared at include/linux/pci.h:481)
> drivers/pci/hotplug/cpqphp_pci.c:102: warning: ???pci_find_slot??? is deprecated (declared at include/linux/pci.h:481)
> drivers/pci/hotplug/cpqphp_pci.c: In function ???cpqhp_unconfigure_device???:
> drivers/pci/hotplug/cpqphp_pci.c:126: warning: ???pci_find_slot??? is deprecated (declared at include/linux/pci.h:481)
> drivers/pci/hotplug/cpqphp_pci.c: In function ???cpqhp_save_config???:
> drivers/pci/hotplug/cpqphp_pci.c:420: warning: ???pci_find_slot??? is deprecated (declared at include/linux/pci.h:481)
>
> Signed-off-by: Joonwoo Park <joonwpark81@gmail.com>
Close, but you need to free the reference that you now have grabed. As
is, this patch will cause a memory leak and cause bad things to happen
:(
Take a look at the documentation for the pci_get_bus_and_slot()
function, it's not as easy as a simple search-and-replace.
thanks,
greg k-h
next prev parent reply other threads:[~2007-10-01 6:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-01 3:09 [PATCH] PCI hotplug : Switch to pci_get_bus_and_slot instead of deprecated pci_find_slot JoonwooPark
2007-10-01 6:10 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-10-01 8:05 Joonwoo Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071001061025.GA11573@suse.de \
--to=gregkh@suse.de \
--cc=joonwpark81@gmail.com \
--cc=kristen.c.accardi@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox