Re: [PATCH] Patches for tiny 386 kernels, again. Linux kernel 2.6.22.7

[Willy Tarreau <w@1wt.eu>]

On Mon, Oct 01, 2007 at 10:28:30AM -0400, Bill Davidsen wrote:
> Lennart Sorensen wrote:
> >On Fri, Sep 28, 2007 at 05:24:20PM -0400, Bill Davidsen wrote:
> >  
> >>I'll offer this suggestion, knowing it may piss you off, given the 
> >>difficulty of preserving whitespace on *many* mailers without using 
> >>attachments, and given that attachments can be saved easily without 
> >>prying them out of the message, why don't you (one person) switch to a 
> >>capable mail agent, if only for patches, instead of trying to teach many 
> >>people to jump through hoops to avoid whitespace issues?
> >>
> >>Not criticizing, just seems easier for everybody for you to avoid 
> >>teaching people things they don't find useful elsewhere, or getting 
> >>discouraged and not bothering.
> >>    
> >
> >Ehm, so you want people to save the patch, then when replying they
> >should load the patch into their (much better) mail client where they
> >can comment on the patch?  That is the reason the patch should be
> >inline.  People need to comment on it just as they would comment on any
> >other plain text email.
> >  
> 
> And in a perfect world everyone would have a mail client which made that 
> easy, no one would be force by company policy or other circumstances to 
> use a client which didn't work the way you think it should, no company 
> or ISP would filter and mangle outgoing mail, and all vendors would 
> understand that pristine patches are more important that all that stuff 
> they do to make business communications look reasonable.
> 
> In my world people send me attachments so they don't get mangled, and if 
> I need to quote them I know how to do so.
> >Well that and some people use git to import patches from the email in a
> >mostly automated way which also expects them to have the info at top
> >with signed-off and then the patch, which attachments also screw up.
> >
> >So yes there are good reasons for getting a non broken mail client when
> >sending patches to lkml.
> >  
> 
> And reading them, many show attached text at the end of the message and 
> make turning it into inline text simple.

Hey, if the poster knows his mail client is broken, nothing prevents him
from attaching the patches (so that they don't get mangled) and at the
same time inline them for an easy review. People who review patches won't
bother about spaces or tabs when you indicate to them from the beginning
that the patch may have been mangled.

Willy