From: Denys Vlasenko <vda.linux@googlemail.com>
To: Greg KH <greg@kroah.com>
Cc: Clemens Ladisch <clemens@ladisch.de>, linux-kernel@vger.kernel.org
Subject: testers needed for drivers/usb/misc/emi*.c
Date: Tue, 2 Oct 2007 18:18:22 +0100 [thread overview]
Message-ID: <200710021818.22236.vda.linux@googlemail.com> (raw)
In-Reply-To: <20071002163532.GA12526@kroah.com>
On Tuesday 02 October 2007 17:35, Greg KH wrote:
> > > > > > I suggest the following optimizations:
> > > > > >
> > > > > > Change structure to
> > > > > >
> > > > > > typedef struct _INTEL_HEX_RECORD
> > > > > > {
> > > > > > __u8 type;
> > > > > > __u8 length;
> > > > > > __u16 address;
> > > > > > __u8 data[MAX_INTEL_HEX_RECORD_LENGTH];
> > > > > > } INTEL_HEX_RECORD __attribute__((__packed__));
> > > > >
> > > > > Only if you redo the whole firmware image too :)
> > > >
> > > > I did. It wasn't hard.
> > >
> > > Great, send me a patch then :)
> >
> > Here is it. Sending off-list due to size.
> >
> > emi.code.patch contains changes to firmware loading code.
> > emi.fw.patch.bz2 contains modified firmware images.
> >
> > I don't have this hardware, thus I wrote test programs which
> > mimic firmware loading in userspace (they dump filrmware
> > in hex to stdout). See testing.tar.bz2.
>
> Can you find someone with this hardware to test this patch? I'll not be
> able to take it until you do as the device might be assuming some of
> these firmware requirements that you changed.
No, I don't know any users who have this device.
Changing subject and CCing lkml, just in case.
--
vda
prev parent reply other threads:[~2007-10-02 17:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-14 10:35 drivers/usb/misc/emi*.c have the biggest data objects in the whole tree Denys Vlasenko
2007-09-18 12:21 ` Clemens Ladisch
2007-09-19 2:47 ` Valdis.Kletnieks
2007-09-28 4:41 ` Greg KH
2007-09-28 11:34 ` Denys Vlasenko
2007-09-28 19:27 ` Greg KH
[not found] ` <200710021018.13905.vda.linux@googlemail.com>
[not found] ` <20071002163532.GA12526@kroah.com>
2007-10-02 17:18 ` Denys Vlasenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710021818.22236.vda.linux@googlemail.com \
--to=vda.linux@googlemail.com \
--cc=clemens@ladisch.de \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox