public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Andrew Morton <akpm@linux-foundation.org>,
	"Torvalds, Linus" <torvalds@linux-foundation.org>,
	linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org
Subject: remove zero_page (was Re: -mm merge plans for 2.6.24)
Date: Wed, 3 Oct 2007 03:45:09 +1000	[thread overview]
Message-ID: <200710030345.10026.nickpiggin@yahoo.com.au> (raw)
In-Reply-To: <20071001142222.fcaa8d57.akpm@linux-foundation.org>

On Tuesday 02 October 2007 07:22, Andrew Morton wrote:

> remove-zero_page.patch
>
>   Linus dislikes it.  Probably drop it.

I don't know if Linus actually disliked the patch itself, or disliked
my (maybe confusingly worded) rationale?

To clarify: it is not zero_page that fundamentally causes a problem,
but it is a problem that was exposed when I rationalised the page
refcounting in the kernel (and mapcounting in the mm).

I see about 4 things we can do:
1. Nothing
2. Remove zero_page
3. Reintroduce some refcount special-casing for the zero page
4. zero_page per-node or per-cpu or whatever

1 and 2 kind of imply that nothing much sane should use the zero_page
much (the former also implies that we don't care much about those who
do, but in that case, why not go for code removal?).

3 and 4 are if we think there are valid heavy users of zero page, or we
are worried about hurting badly written apps by removing it. If the former,
I'd love to hear about them; if the latter, then it definitely is a valid
concern and I have a patch to avoid refcounting (but if this is the case
then I do hope that one day we can eventually remove it).


> mm-use-pagevec-to-rotate-reclaimable-page.patch
> mm-use-pagevec-to-rotate-reclaimable-page-fix.patch
> mm-use-pagevec-to-rotate-reclaimable-page-fix-2.patch
> mm-use-pagevec-to-rotate-reclaimable-page-fix-function-declaration.patch
> mm-use-pagevec-to-rotate-reclaimable-page-fix-bug-at-include-linux-mmh220.p
>atch
> mm-use-pagevec-to-rotate-reclaimable-page-kill-redundancy-in-rotate_reclaim
>able_page.patch
> mm-use-pagevec-to-rotate-reclaimable-page-move_tail_pages-into-lru_add_drai
>n.patch
>
>   I guess I'll merge this.  Would be nice to have wider perfromance testing
>   but I guess it'll be easy enough to undo.

Care to give it one more round through -mm? Is it easy enough to
keep? I haven't had a chance to review it, which I'd like to do at some
point (and I don't think it would hurt to have a bit more testing).

  parent reply	other threads:[~2007-10-03 10:28 UTC|newest]

Thread overview: 112+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-01 21:22 -mm merge plans for 2.6.24 Andrew Morton
2007-10-01 21:34 ` wibbling over the cpuset shed domain connnection Paul Jackson
2007-10-02 12:36   ` Nick Piggin
2007-10-03  5:21     ` Paul Jackson
2007-10-02 13:12       ` Nick Piggin
2007-10-03  7:00         ` Paul Jackson
2007-10-03 10:57           ` Andrew Morton
2007-10-02  4:21 ` Memory controller merge (was Re: -mm merge plans for 2.6.24) Balbir Singh
2007-10-02 15:46   ` Hugh Dickins
2007-10-03  8:13     ` Balbir Singh
2007-10-03 18:47       ` Hugh Dickins
2007-10-04  4:16         ` Balbir Singh
2007-10-04 13:16           ` Hugh Dickins
2007-10-05  3:07             ` Balbir Singh
2007-10-07 17:41               ` Hugh Dickins
2007-10-08  2:54                 ` Balbir Singh
2007-10-04 16:10     ` Paul Menage
2007-10-10 21:07   ` Rik van Riel
2007-10-11  6:33     ` Balbir Singh
2007-10-02  6:18 ` x86 patches was Re: -mm merge plans for 2.6.24 Andi Kleen
2007-10-02  6:32   ` Andrew Morton
2007-10-02  7:01     ` Andi Kleen
2007-10-02  7:18       ` Andrew Morton
2007-10-02  7:36         ` KAMEZAWA Hiroyuki
2007-10-02  7:43           ` Andrew Morton
2007-10-02  8:16             ` KAMEZAWA Hiroyuki
2007-10-02 10:48               ` Yasunori Goto
2007-10-02 18:18               ` Christoph Lameter
2007-10-02 17:25             ` Lee Schermerhorn
2007-10-02 16:40           ` Nish Aravamudan
2007-10-02 17:17           ` Lee Schermerhorn
2007-10-02 18:16           ` Christoph Lameter
2007-10-02  7:55         ` Matt Mackall
2007-10-02  7:59           ` Andi Kleen
2007-10-02  9:26       ` Andy Whitcroft
2007-10-02  7:37     ` Ingo Molnar
2007-10-02  7:46       ` Andi Kleen
2007-10-02  7:58         ` Thomas Gleixner
2007-10-02  7:59 ` v4l-stk11xx* [Was: -mm merge plans for 2.6.24] Jiri Slaby
     [not found] ` <4701FC79.3060608@gmail.com>
2007-10-02  8:10   ` Wireless damage " Jiri Slaby
2007-10-02  8:17 ` per BDI dirty limit (was Re: -mm merge plans for 2.6.24) Peter Zijlstra
     [not found]   ` <20071002082831.GA19954@mail.ustc.edu.cn>
2007-10-02  8:28     ` Fengguang Wu
2007-10-02  8:31   ` Andrew Morton
2007-10-02  8:48     ` Peter Zijlstra
2007-10-02 10:31       ` Kay Sievers
2007-10-02 10:44         ` Peter Zijlstra
     [not found]           ` <20071002104734.GA9410@mail.ustc.edu.cn>
2007-10-02 10:47             ` Fengguang Wu
2007-10-02 11:22               ` Kay Sievers
     [not found]                 ` <20071002112802.GA12607@mail.ustc.edu.cn>
2007-10-02 11:28                   ` Fengguang Wu
2007-10-02 11:21           ` Kay Sievers
2007-10-02 11:40             ` Peter Zijlstra
2007-10-02 12:05               ` Nick Piggin
2007-10-03 10:15                 ` Kay Sievers
2007-10-03 10:37                   ` Peter Zijlstra
2007-10-03 13:35                     ` Kay Sievers
2007-10-03 13:58                       ` Peter Zijlstra
2007-10-26 14:48                       ` Peter Zijlstra
2007-10-26 15:06                         ` Miklos Szeredi
2007-10-26 15:10                         ` Kay Sievers
2007-10-26 15:22                           ` Peter Zijlstra
2007-10-26 15:33                             ` Kay Sievers
2007-10-26 15:33                               ` Peter Zijlstra
2007-10-26 15:55                                 ` Kay Sievers
2007-10-26 20:04                                   ` Peter Zijlstra
2007-10-27  1:18                                     ` Peter Zijlstra
2007-10-27  2:40                                       ` Greg KH
2007-10-27  8:39                                         ` Peter Zijlstra
2007-10-27 16:02                                           ` Greg KH
2007-10-27 16:07                                             ` Peter Zijlstra
2007-10-27 21:08                                             ` Kay Sievers
2007-10-27 21:35                                               ` Peter Zijlstra
2007-10-28  7:10                                                 ` Greg KH
2007-11-02 13:15                                               ` Peter Zijlstra
2007-11-02 13:50                                                 ` Kay Sievers
2007-11-02 13:54                                                   ` Peter Zijlstra
2007-11-02 14:17                                                   ` Peter Zijlstra
2007-11-02 14:32                                                     ` Kay Sievers
2007-11-02 14:59                                                       ` [PATCH] mm: sysfs: expose the BDI object in sysfs Peter Zijlstra
2007-11-02 15:13                                                         ` Kay Sievers
2007-10-26 16:37                         ` per BDI dirty limit (was Re: -mm merge plans for 2.6.24) Trond Myklebust
2007-12-14 14:50                           ` Peter Zijlstra
2007-12-14 15:14                             ` Miklos Szeredi
2007-12-14 15:54                               ` Peter Zijlstra
2007-10-02 14:38               ` Kay Sievers
2007-10-03 11:00   ` Martin Knoblauch
     [not found] ` <20071002083922.GA28892@mail.ustc.edu.cn>
2007-10-02  8:39   ` writeback fixes Fengguang Wu
2007-10-02 16:06 ` kswapd min order, slub max order [was Re: -mm merge plans for 2.6.24] Hugh Dickins
2007-10-02  9:10   ` Nick Piggin
2007-10-02 18:38   ` Mel Gorman
2007-10-02 18:28     ` Christoph Lameter
2007-10-03  0:37       ` Christoph Lameter
2007-10-02 16:12 ` -mm merge plans for 2.6.24 Pekka Enberg
2007-10-02 16:21 ` new aops merge [was Re: -mm merge plans for 2.6.24] Hugh Dickins
2007-10-02 17:45 ` Nick Piggin [this message]
2007-10-03 10:58   ` remove zero_page (was Re: -mm merge plans for 2.6.24) Andrew Morton
2007-10-03 15:21   ` Linus Torvalds
2007-10-08 15:17     ` Nick Piggin
2007-10-09 13:00       ` Hugh Dickins
2007-10-09 14:52       ` Linus Torvalds
2007-10-09  9:31         ` Nick Piggin
2007-10-10  2:22           ` Linus Torvalds
2007-10-09 10:15             ` Nick Piggin
2007-10-10  3:06               ` Linus Torvalds
2007-10-10  4:06               ` Hugh Dickins
2007-10-10  5:20                 ` Linus Torvalds
2007-10-09 14:30                   ` Nick Piggin
2007-10-10 15:04                     ` Linus Torvalds
2007-10-03 19:50 ` A kernel Tracing interface " David Wilder
2007-10-09  9:19 ` r/o bind mounts, was Re: -mm merge plans for 2.6.24 Christoph Hellwig
2007-10-13  8:44 ` Borislav Petkov
2007-10-13  8:52   ` Andrew Morton
2007-10-13 11:45     ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200710030345.10026.nickpiggin@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox