From: Jens Axboe <jens.axboe@oracle.com>
To: Pierre Ossman <drzeus@drzeus.cx>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Don Mullis <dwm@meer.net>,
linux-kernel@vger.kernel.org
Subject: Re: 2.6.23-rc8-mm2: OOPS in mmc on boot
Date: Thu, 4 Oct 2007 12:38:05 +0200 [thread overview]
Message-ID: <20071004103805.GB5711@kernel.dk> (raw)
In-Reply-To: <20071004122439.0944f3db@poseidon.drzeus.cx>
On Thu, Oct 04 2007, Pierre Ossman wrote:
> On Thu, 4 Oct 2007 11:30:14 +0200
> Jens Axboe <jens.axboe@oracle.com> wrote:
>
> > On Thu, Oct 04 2007, Pierre Ossman wrote:
> > >
> > > I assume sg_init_one() still can work on an uninitialized sg entry?
> >
> > Yes, but only if that sg entry is not part of a chained list.
> >
>
> Is that a yes or a no? You said that the ->page field was involved in
It's a conditional yes, re-read it :-)
> list chaining, so does or doesn't it have to be initialized before a
> call to sg_init_one()?
That's not the problem. It has to be initialized before calling
blk_rq_map_sg(). sg_init_one() will zero the entire sg entry, and that
breaks if that particular sg entry is part of a larger sg table AND that
sg entry happens to be the chain element.
--
Jens Axboe
next prev parent reply other threads:[~2007-10-04 10:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-04 6:11 2.6.23-rc8-mm2: OOPS in mmc on boot Don Mullis
2007-10-04 6:16 ` Andrew Morton
2007-10-04 7:25 ` Jens Axboe
2007-10-04 8:01 ` Pierre Ossman
2007-10-04 8:06 ` Jens Axboe
2007-10-04 8:46 ` Pierre Ossman
2007-10-04 9:30 ` Jens Axboe
2007-10-04 10:24 ` Pierre Ossman
2007-10-04 10:38 ` Jens Axboe [this message]
2007-10-04 10:46 ` Pierre Ossman
2007-10-04 10:59 ` Jens Axboe
2007-10-04 16:19 ` Don Mullis
2007-10-04 16:35 ` Pierre Ossman
2007-10-04 16:42 ` Jens Axboe
2007-10-04 16:46 ` Pierre Ossman
2007-10-04 17:06 ` Don Mullis
2007-10-04 18:10 ` Jens Axboe
2007-10-04 7:28 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071004103805.GB5711@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=drzeus@drzeus.cx \
--cc=dwm@meer.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox