From: Matt Mackall <mpm@selenic.com>
To: Pavel Emelyanov <xemul@openvz.org>
Cc: Andrew Morton <akpm@osdl.org>,
Sukadev Bhattiprolu <sukadev@us.ibm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devel@openvz.org
Subject: Re: [PATCH 2/3] Prepare pid_nr() etc functions to work with not-NULL pids
Date: Thu, 4 Oct 2007 12:13:11 -0500 [thread overview]
Message-ID: <20071004171311.GZ19691@waste.org> (raw)
In-Reply-To: <4704AA39.5030208@openvz.org>
On Thu, Oct 04, 2007 at 12:54:17PM +0400, Pavel Emelyanov wrote:
> Matt Mackall wrote:
> > On Wed, Oct 03, 2007 at 06:20:43PM +0400, Pavel Emelyanov wrote:
> >> Just make the __pid_nr() etc functions that expect the argument
> >> to always be not NULL.
> >>
> >> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
> >
> >> static inline pid_t pid_nr(struct pid *pid)
> >> {
> >> pid_t nr = 0;
> >> if (pid)
> >> - nr = pid->numbers[0].nr;
> >> + nr = __pid_nr(pid);
> >> return nr;
> >> }
> >
> > Is there a patch that removes these inlines? Otherwise this looks good
> > to me.
>
> Not yet. Some of are uninlined already, but others are not. I'd like
> to make some testing before uninline them.
I was asking about the whole function, actually, not the keyword. Is
this function not equivalent to __pid_nr now?
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2007-10-04 23:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-03 14:16 [PATCH 0/3] Make tasks always have non-zero pids Pavel Emelyanov
2007-10-03 14:19 ` [PATCH 1/3] Introduce the dummy_pid Pavel Emelyanov
2007-10-03 18:06 ` Randy Dunlap
2007-10-04 8:56 ` Pavel Emelyanov
2007-10-03 14:20 ` [PATCH 2/3] Prepare pid_nr() etc functions to work with not-NULL pids Pavel Emelyanov
2007-10-03 16:42 ` Matt Mackall
2007-10-04 8:54 ` Pavel Emelyanov
2007-10-04 17:13 ` Matt Mackall [this message]
2007-10-05 13:16 ` Pavel Emelyanov
2007-10-03 14:23 ` [PATCH 3/3] Use the __pid_nr() calls where appropriate Pavel Emelyanov
2007-10-05 5:53 ` [PATCH 0/3] Make tasks always have non-zero pids sukadev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071004171311.GZ19691@waste.org \
--to=mpm@selenic.com \
--cc=akpm@osdl.org \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sukadev@us.ibm.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox