From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759469AbXJDUkc (ORCPT ); Thu, 4 Oct 2007 16:40:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756464AbXJDUkZ (ORCPT ); Thu, 4 Oct 2007 16:40:25 -0400 Received: from mga07.intel.com ([143.182.124.22]:23968 "EHLO azsmga101.ch.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755990AbXJDUkY (ORCPT ); Thu, 4 Oct 2007 16:40:24 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.21,232,1188802800"; d="scan'208";a="292820871" Date: Thu, 4 Oct 2007 13:39:52 -0700 From: Mark Gross To: Andrew Morton Cc: arjan@infradead.org, linux-pm@lists.linux-foundation.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, mark.gross@intel.com Subject: Re: [PATCH] PM_QOS 1 of 2 Message-ID: <20071004203952.GB19803@linux.intel.com> Reply-To: mgross@linux.intel.com References: <20071001234528.GA5238@linux.intel.com> <20071004125356.69e01dfe.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071004125356.69e01dfe.akpm@linux-foundation.org> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 04, 2007 at 12:53:56PM -0700, Andrew Morton wrote: > On Mon, 1 Oct 2007 16:45:28 -0700 > Mark Gross wrote: > > > The following is the cleaned up patch implementing the power management > > quality of service infrastructure discussed at the pm summit last June. > > > > It is a genralization of the latency code put into the kernel last year > > by Arjan. > > > > I would like to get this code included in the MM tree and to get some > > milage on it. > > > > One thing to note about this implementation is that it exposes an > > interface to user space for registering pm_qos constraints in addition > > to the kernel exports. Its a file based interface where a module can > > register a constraint and the constraint is valid only as long as the > > device node is held open. Upon closing of the device node that > > constraint is cleaned up. > > > > The patch set is in two postings. > > 1) the base parameter code (this email) > > 2) replacing of latency.c/latenc.h with pm_qos_params.c/pm_qos_params.h > > I wouldn't really view this as an adequate changelog. > > - The Subject:s are pretty pathetic (please see my suggesed replacements) uhg. Your right. > > - There is no description of the proposed new kernel<->userspace > interfaces. > the above description is light on specific details. > As you are proposing new and permanent enhancements to the Linux API, > this is something which should be spelled out in some detail. Because we > can change the implementation, but we can not ever change your interface. > > It would be nice to get that interface described in Documentation/ > somewhere, but it is *critical* that the design be fully revealed right > now, during review. I'll provide this. > > > Anyway, I am not a suitable person to review this submission. > > I'll put the patches in -mm for a bit of eyeball-and-test (not that anyone > will know how to test it, due to the secret interfaces) but I do not want > to move this code into mainline until someone who is familiar with the PM > code has performed a detailed review of both the implementation and the > design (whatever that is!). > > Please send new, complete descriptions of these patches. I don't think > they can be effectively reviewed without that information. Except perhaps > by someone who was at the PM summit, but that's cheating. > I will do this. --mgross