Re: [PATCH] block: move ioctl conversion to compat_blkdev_ioctl

Jens Axboe
2007-10-05T12:40:38Z

On Fri, Oct 05 2007, Arnd Bergmann wrote:
> fs/compat_ioctl.c is still a mess and I'd prefer to get rid of it
> over time, by moving everything to the respective drivers.
>
> A significant portion of our ioctl numbers are common to a number
> of block drivers, so should not handle them in each driver separately,
> but rather in the block layer.
>
> In the process, we remove a few indirections from the call graph
> for compat block ioctls. This patch is still an entirely untested
> preview and should be split into smaller chunks.

As before, this looks pretty good. I'll toss it in the tester and see if
things still work.

--
Jens Axboe