From: Jens Axboe <jens.axboe@oracle.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org, davem@davemloft.net, hch@lst.de,
Al Viro <viro@ftp.linux.org.uk>
Subject: Re: [PATCH] block: move ioctl conversion to compat_blkdev_ioctl
Date: Fri, 5 Oct 2007 14:41:53 +0200 [thread overview]
Message-ID: <20071005124153.GT5711@kernel.dk> (raw)
In-Reply-To: <200710051430.39792.arnd@arndb.de>
On Fri, Oct 05 2007, Arnd Bergmann wrote:
> fs/compat_ioctl.c is still a mess and I'd prefer to get rid of it
> over time, by moving everything to the respective drivers.
>
> A significant portion of our ioctl numbers are common to a number
> of block drivers, so should not handle them in each driver separately,
> but rather in the block layer.
>
> In the process, we remove a few indirections from the call graph
> for compat block ioctls. This patch is still an entirely untested
> preview and should be split into smaller chunks.
As before, this looks pretty good. I'll toss it in the tester and see if
things still work.
--
Jens Axboe
next prev parent reply other threads:[~2007-10-05 12:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-02 7:39 [PATCH] Fix blktrace setup 32-bit ioctl on 64-bit kernels Jens Axboe
2007-10-02 7:52 ` David Miller
2007-10-02 8:15 ` Arnd Bergmann
2007-10-02 8:37 ` Jens Axboe
2007-10-02 9:28 ` Jens Axboe
2007-10-03 9:34 ` Arnd Bergmann
2007-10-03 15:55 ` Arnd Bergmann
2007-10-03 22:48 ` Arnd Bergmann
2007-10-04 18:16 ` Jens Axboe
2007-10-04 18:44 ` Arnd Bergmann
2007-10-05 10:41 ` Jens Axboe
2007-10-05 12:30 ` [PATCH] block: move ioctl conversion to compat_blkdev_ioctl Arnd Bergmann
2007-10-05 12:41 ` Jens Axboe [this message]
2007-10-05 12:41 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071005124153.GT5711@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox