public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dbrownell@users.sourceforge.net
Cc: linux-usb-users@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, greg@kroah.com
Subject: OHCI root_port_reset() deadly loop...
Date: Sat, 06 Oct 2007 23:53:58 -0700 (PDT)	[thread overview]
Message-ID: <20071006.235358.104048815.davem@davemloft.net> (raw)


When root_port_reset() in ohci-hub.c polls for the end of the reset,
it puts no limit on the loop and will only exit the loop when either
the RH_PS_PRS bit clears or the register returns all 1's (the latter
condition is a recent addition).

If for some reason the bit never clears, we sit here forever and never
exit the loop.

I actually hit this on one of my machines, and I'm trying to track
down what's happening.

Regardless of why my machine is doing this, there absolutely should be
some upper bound put on the number of times we will run through this
loop, perhaps enough such that up to 5 seconds elapses waiting for the
reset bit to clear.  And if it times out we should print a loud
message onto the console, but still try to continue.

Thanks!

             reply	other threads:[~2007-10-07  6:54 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-07  6:53 David Miller [this message]
2007-10-07  7:31 ` OHCI root_port_reset() deadly loop David Brownell
2007-10-07  7:51   ` David Miller
2007-10-08 23:54     ` David Miller
2007-10-09  3:10       ` Greg KH
2007-10-09  3:16         ` David Miller
2007-10-09  3:34           ` David Brownell
2007-10-09  3:42             ` David Miller
2007-10-09  4:39               ` Greg KH
2007-10-09  4:47                 ` David Miller
2007-10-09  5:11                   ` Benjamin Herrenschmidt
2007-10-09  6:06                   ` Greg KH
2007-10-09 19:22                     ` [linux-usb-devel] " David Brownell
2007-10-10 15:32                       ` Alan Stern
2007-10-09  5:00                 ` David Brownell
2007-10-09  5:23                   ` David Miller
2007-10-09  6:43                   ` Benjamin Herrenschmidt
2007-10-09 18:48                     ` David Brownell
2007-10-09 16:01           ` [Linux-usb-users] " Alan Stern
2007-10-09 17:39             ` Greg KH
2007-10-09 18:42               ` Alan Stern
2007-10-09 18:59                 ` David Brownell
2007-10-09 21:27                 ` David Miller
2007-10-09 21:43                   ` David Brownell
2007-10-09 22:00                     ` David Miller
2007-10-10  4:35                       ` David Miller
2007-10-15 22:01                         ` David Miller
2007-10-15 23:39                           ` David Brownell
2007-10-15 23:58                             ` David Miller
2007-10-16 15:23                               ` Alan Stern
2007-10-16 22:06                                 ` David Miller
2007-10-16 22:20                                   ` Greg KH
2007-10-17 15:56                                     ` Alan Stern
2007-10-16 22:08                                 ` David Miller
2007-10-17 15:51                                   ` Alan Stern
2007-10-17 23:03                                     ` David Miller
2007-10-18 14:28                                       ` Alan Stern
2007-10-16 18:26                               ` David Brownell
2007-10-09  4:09       ` David Brownell
2007-10-09  5:13         ` Benjamin Herrenschmidt
2007-10-09  5:26           ` David Miller
2007-10-09  6:37             ` Benjamin Herrenschmidt
2007-10-09  4:36       ` David Brownell
2007-10-09  4:44         ` David Miller
2007-10-09 16:38           ` David Brownell
2007-10-09 20:41             ` David Miller
2007-10-09 20:46               ` Greg KH
2007-10-09 21:05                 ` David Brownell
2007-10-09 21:09               ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071006.235358.104048815.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dbrownell@users.sourceforge.net \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-users@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox