From: WANG Cong <xiyou.wangcong@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Wim Van Sebroeck <wim@iguana.be>, Andrew Morton <akpm@osdl.org>
Subject: [Patch]Documentation/watchdog/src/watchdog-simple.c: improve this code
Date: Sat, 6 Oct 2007 11:17:13 +0800 [thread overview]
Message-ID: <20071006031713.GE2436@hacking> (raw)
Make some improvements for Documentation/watchdog/src/watchdog-simple.c.
CC: Wim Van Sebroeck <wim@iguana.be>
Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
---
Documentation/watchdog/src/watchdog-simple.c | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
Index: linux-2.6.23-rc9/Documentation/watchdog/src/watchdog-simple.c
===================================================================
--- linux-2.6.23-rc9.orig/Documentation/watchdog/src/watchdog-simple.c
+++ linux-2.6.23-rc9/Documentation/watchdog/src/watchdog-simple.c
@@ -3,15 +3,24 @@
#include <unistd.h>
#include <fcntl.h>
-int main(int argc, const char *argv[]) {
+int main(void) {
int fd = open("/dev/watchdog", O_WRONLY);
+ int ret = 0;
if (fd == -1) {
perror("watchdog");
- exit(1);
+ exit(EXIT_FAILURE);
}
while (1) {
- write(fd, "\0", 1);
- fsync(fd);
+ ret = write(fd, "\0", 1);
+ if (ret != 1) {
+ ret = -1;
+ break;
+ }
+ ret = fsync(fd);
+ if (ret)
+ break;
sleep(10);
}
+ close(fd);
+ return ret;
}
reply other threads:[~2007-10-06 3:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071006031713.GE2436@hacking \
--to=xiyou.wangcong@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox