public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kyle McMartin <kyle@mcmartin.ca>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: dri-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
	airlied@linux.ie, arashi@sacredchao.net
Subject: Revert "intel_agp: fix stolen mem range on G33"
Date: Sat, 6 Oct 2007 01:42:34 -0400	[thread overview]
Message-ID: <20071006054234.GC14767@fattire.cabal.ca> (raw)
In-Reply-To: <20071006053410.GB14767@fattire.cabal.ca>

This reverts commit f443675affe3f16dd428e46f0f7fd3f4d703eeab, which
breaks horribly if you aren't running an unreleased xf86-video-intel
driver out of git.

Conflicts:

	drivers/char/agp/intel-agp.c

Signed-off-by: Kyle McMartin <kyle@mcmartin.ca>
---

 drivers/char/agp/intel-agp.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c
index a5d0e95..141ca17 100644
--- a/drivers/char/agp/intel-agp.c
+++ b/drivers/char/agp/intel-agp.c
@@ -506,11 +506,6 @@ static void intel_i830_init_gtt_entries(void)
 			break;
 		}
 	} else {
-		/* G33's GTT stolen memory is separate from gfx data
-		 * stolen memory.
-		 */
-		if (IS_G33)
-			size = 0;
 		switch (gmch_ctrl & I855_GMCH_GMS_MASK) {
 		case I855_GMCH_GMS_STOLEN_1M:
 			gtt_entries = MB(1) - KB(size);
-- 
1.5.3.3

On Sat, Oct 06, 2007 at 01:34:10AM -0400, Kyle McMartin wrote:
> On Sat, Oct 06, 2007 at 12:42:21AM -0400, Kyle McMartin wrote:
> > commit f443675affe3f16dd428e46f0f7fd3f4d703eeab
> >     intel_agp: fix stolen mem range on G33
> >     G33 GTT stolen memory is below graphics data stolen memory and be seperate,
> >     so don't subtract it in stolen mem counting.
> >     
> 
> Found it, without this corresponding change to xf86-video-intel, this
> breaks utterly:
> 
> commit 2a8592f2ebcba86b1127aa889155d58a3dc186ca
> Author: Zhenyu Wang <zhenyu.z.wang@intel.com>
> Date:   Wed Sep 5 14:52:56 2007 +0800
> 
>     Fix G33 GTT stolen mem range
>     
>     G33 GTT table lives in seperate stolen mem with
>     graphics data stolen mem.
> 
> I think this should be reverted for 2.6.23, it certainly doesn't seem to have
> been appropriate for 2.6.23-rc6.
> 
> Cheers,
> 	Kyle M.
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

  reply	other threads:[~2007-10-06  5:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-06  0:20 G33 graphics broken after 2.6.23-rc6 Matthew Reppert
2007-10-06  4:42 ` Kyle McMartin
2007-10-06  5:34   ` Kyle McMartin
2007-10-06  5:42     ` Kyle McMartin [this message]
2007-10-06 10:41       ` Revert "intel_agp: fix stolen mem range on G33" Jiri Slaby
2007-10-06 15:59         ` Linus Torvalds
2007-10-06 19:29           ` Keith Packard
2007-10-07 10:05             ` Jiri Slaby
2007-10-07 12:17         ` Daniel Stone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071006054234.GC14767@fattire.cabal.ca \
    --to=kyle@mcmartin.ca \
    --cc=airlied@linux.ie \
    --cc=arashi@sacredchao.net \
    --cc=dri-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox