public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [TRIVIAL PATCH] Remove unused variable in drivers/dma/ioatdma.c
@ 2007-10-07 19:18 Johannes Weiner
  2007-10-07 21:05 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Johannes Weiner @ 2007-10-07 19:18 UTC (permalink / raw)
  To: Linux Kernel Mailing List; +Cc: trivial

Hi,

I found this in an `allyesconfig' build:

  CC      drivers/dma/ioatdma.o
  drivers/dma/ioatdma.c: In function #ioat_dma_free_chan_resources#:
  drivers/dma/ioatdma.c:247: warning: unused variable #chanctrl#

	Hannes

Signed-off-by: Johannes Weiner <hannes-kernel@saeurebad.de>

diff --git a/drivers/dma/ioatdma.c b/drivers/dma/ioatdma.c
index 41b18c5..d9db64b 100644
--- a/drivers/dma/ioatdma.c
+++ b/drivers/dma/ioatdma.c
@@ -244,7 +244,6 @@ static void ioat_dma_free_chan_resources(struct dma_chan *chan)
 	struct ioat_dma_chan *ioat_chan = to_ioat_chan(chan);
 	struct ioat_device *ioat_device = to_ioat_device(chan->device);
 	struct ioat_desc_sw *desc, *_desc;
-	u16 chanctrl;
 	int in_use_descs = 0;
 
 	ioat_dma_memcpy_cleanup(ioat_chan);

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [TRIVIAL PATCH] Remove unused variable in drivers/dma/ioatdma.c
  2007-10-07 19:18 [TRIVIAL PATCH] Remove unused variable in drivers/dma/ioatdma.c Johannes Weiner
@ 2007-10-07 21:05 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2007-10-07 21:05 UTC (permalink / raw)
  To: hannes-kernel; +Cc: linux-kernel, trivial, akpm

From: Johannes Weiner <hannes-kernel@saeurebad.de>
Date: Sun, 7 Oct 2007 21:18:49 +0200

> Hi,
> 
> I found this in an `allyesconfig' build:
> 
>   CC      drivers/dma/ioatdma.o
>   drivers/dma/ioatdma.c: In function #ioat_dma_free_chan_resources#:
>   drivers/dma/ioatdma.c:247: warning: unused variable #chanctrl#
> 
> 	Hannes
> 
> Signed-off-by: Johannes Weiner <hannes-kernel@saeurebad.de>

This exists as a patch in -mm for what seems like months.

I can't believe this one-liner hasn't been merged yet, it's
silly.

I was even chastised at one point for merging it into my net-2.6.24
tree :-)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-10-07 21:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-07 19:18 [TRIVIAL PATCH] Remove unused variable in drivers/dma/ioatdma.c Johannes Weiner
2007-10-07 21:05 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox