From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755356AbXJHMD1 (ORCPT ); Mon, 8 Oct 2007 08:03:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753964AbXJHMDT (ORCPT ); Mon, 8 Oct 2007 08:03:19 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:40034 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754035AbXJHMDT (ORCPT ); Mon, 8 Oct 2007 08:03:19 -0400 Date: Mon, 8 Oct 2007 14:03:06 +0200 From: Ingo Molnar To: Andi Kleen Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] [2/6] scheduler: Refactor common code of sleep_on / wait_for_completion v2 Message-ID: <20071008120306.GA28191@elte.hu> References: <200710071059.126674000@suse.de> <20071007205955.4D60E1474B@wotan.suse.de> <20071008113906.GB22199@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071008113906.GB22199@elte.hu> User-Agent: Mutt/1.5.14 (2007-02-12) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.1.7-deb -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org * Ingo Molnar wrote: > * Andi Kleen wrote: > > > Andi Kleen writes: > > > > > These functions were largely cut'n'pasted. This moves > > > > Here's a replacement patch fixing a minor problem: > > sleep_on_common wasn't marked __sched and ended up in the > > wrong section; breaking the WCHAN backtracing. > > thanks, applied. btw., this is a very nice cleanup, the .text savings are particularly impressive: text data bss dec hex filename 24545 2406 16 26967 6957 sched.o.before 23687 2406 16 26109 65fd sched.o.after almost 1K of text shaven off! :) Ingo