public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: torvalds@osdl.org, mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: [PATCH for 2.6.23] Fix scheduler domain sysctl list
Date: Tue, 9 Oct 2007 12:02:24 +0200	[thread overview]
Message-ID: <20071009100224.GA22834@wotan.suse.de> (raw)


Ingo has this already fixed in sched-devel (but he also adds
more parameters here). Since the fix is very simple I think it should
be fixed for .23. Especially cache_nice_tries is useful to tune
because it is very magic and the current values are a little dubious.

----

Fix holes in the scheduler domain sysctl setup that prevented
reaching the last two parameters.

Also allocate array of the correct size.

Signed-off-by: Andi Kleen <ak@suse.de>

Index: linux-2.6.23-rc8-misc/kernel/sched.c
===================================================================
--- linux-2.6.23-rc8-misc.orig/kernel/sched.c
+++ linux-2.6.23-rc8-misc/kernel/sched.c
@@ -5224,7 +5224,7 @@ set_table_entry(struct ctl_table *entry,
 static struct ctl_table *
 sd_alloc_ctl_domain_table(struct sched_domain *sd)
 {
-	struct ctl_table *table = sd_alloc_ctl_entry(14);
+	struct ctl_table *table = sd_alloc_ctl_entry(11);
 
 	set_table_entry(&table[0], "min_interval", &sd->min_interval,
 		sizeof(long), 0644, proc_doulongvec_minmax);
@@ -5244,10 +5244,10 @@ sd_alloc_ctl_domain_table(struct sched_d
 		sizeof(int), 0644, proc_dointvec_minmax);
 	set_table_entry(&table[8], "imbalance_pct", &sd->imbalance_pct,
 		sizeof(int), 0644, proc_dointvec_minmax);
-	set_table_entry(&table[10], "cache_nice_tries",
+	set_table_entry(&table[9], "cache_nice_tries",
 		&sd->cache_nice_tries,
 		sizeof(int), 0644, proc_dointvec_minmax);
-	set_table_entry(&table[12], "flags", &sd->flags,
+	set_table_entry(&table[10], "flags", &sd->flags,
 		sizeof(int), 0644, proc_dointvec_minmax);
 
 	return table;

             reply	other threads:[~2007-10-09 10:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-09 10:02 Andi Kleen [this message]
2007-10-09 10:26 ` [PATCH for 2.6.23] Fix scheduler domain sysctl list Ingo Molnar
2007-10-09 11:07   ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071009100224.GA22834@wotan.suse.de \
    --to=ak@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox