public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Andi Kleen <andi@firstfloor.org>,
	kbuild devel <kbuild-devel@lists.sourceforge.net>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC/RFT] kbuild: save ARCH & CROSS_COMPILE
Date: Tue, 9 Oct 2007 13:08:45 +0200	[thread overview]
Message-ID: <20071009110845.GA28570@one.firstfloor.org> (raw)
In-Reply-To: <20071009100030.GA22475@uranus.ravnborg.org>

On Tue, Oct 09, 2007 at 12:00:30PM +0200, Sam Ravnborg wrote:
> On Tue, Oct 09, 2007 at 11:39:21AM +0200, Andi Kleen wrote:
> > Sam Ravnborg <sam@ravnborg.org> writes:
> > >  
> > > -ARCH		?= $(SUBARCH)
> > > -CROSS_COMPILE	?=
> > 
> > Can you do this in a way that there are still these ARCH/CROSS_COMPILE
> > lines that are just overriden when empty or have their default value? 
> > 
> > This way defaults could be still patched in for special cases.
> 
> If it is OK to drop the $(SUBARCH) assingment like this then yes.
> ARCH		?=
> CROSS_COMPILE	?=

As long as both UML and normal architectures work still out of the 
box yes

> I was wondering why we had the empty CROSS_COMPILE assigment and this
> explains why.
> But why patch something in here in the fisrt place?
> It seems to be a workaround for the actual issue this patch addresses - no?

Mostly.

The difference is that Kbuild.config would likely contain other stuff
too that might be not fit into a patch? Ok it's not a big difference.

-Andi


  reply	other threads:[~2007-10-09 11:08 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-08 20:02 [RFC/RFT] kbuild: save ARCH & CROSS_COMPILE Sam Ravnborg
2007-10-08 20:50 ` Oleg Verych
2007-10-09  4:17   ` Sam Ravnborg
2007-10-09  4:53     ` Randy Dunlap
2007-10-09  5:28       ` Randy Dunlap
2007-10-09  6:01       ` Sam Ravnborg
2007-10-09  8:37     ` Oleg Verych
2007-10-08 21:12 ` Adrian Bunk
2007-10-08 21:20   ` Giacomo Catenazzi
2007-10-09  6:03   ` Sam Ravnborg
2007-10-09  9:54     ` Adrian Bunk
2007-10-09  9:39 ` Andi Kleen
2007-10-09 10:00   ` Sam Ravnborg
2007-10-09 11:08     ` Andi Kleen [this message]
2007-10-09 14:09     ` Jeff Dike
2007-10-09 16:34       ` Sam Ravnborg
2007-10-09 17:44         ` Jeff Dike
2007-10-10  2:35 ` Kristoffer Ericson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071009110845.GA28570@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=kbuild-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox