public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH -mm] fix wrong /proc/cpuinfo output
@ 2007-10-09 10:43 Akinobu Mita
  2007-10-09 13:32 ` Ahmed S. Darwish
  0 siblings, 1 reply; 2+ messages in thread
From: Akinobu Mita @ 2007-10-09 10:43 UTC (permalink / raw)
  To: linux-kernel; +Cc: Mike Travis, Andrew Morton

This patch fixes the problem introduced by:
http://kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc8/2.6.23-rc8-mm2/broken-out/x86-convert-cpuinfo_x86-array-to-a-per_cpu-array.patch

The problem is that every processor line in /proc/cpuinfo displays zero
on x86_64.

$ grep processor /proc/cpuinfo
processor       : 0
processor       : 0

Because early_identify_cpu() overwrites c->cpu_index for every cpuinfo.
This patch removes that unnecessary initialization for c->cpu_index.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>

Index: 2.6-mm/arch/x86_64/kernel/setup.c
===================================================================
--- 2.6-mm.orig/arch/x86_64/kernel/setup.c
+++ 2.6-mm/arch/x86_64/kernel/setup.c
@@ -967,7 +967,6 @@ void __cpuinit early_identify_cpu(struct
 
 #ifdef CONFIG_SMP
 	c->phys_proc_id = (cpuid_ebx(1) >> 24) & 0xff;
-	c->cpu_index = 0;
 #endif
 	/* AMD-defined flags: level 0x80000001 */
 	xlvl = cpuid_eax(0x80000000);

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -mm] fix wrong /proc/cpuinfo output
  2007-10-09 10:43 [PATCH -mm] fix wrong /proc/cpuinfo output Akinobu Mita
@ 2007-10-09 13:32 ` Ahmed S. Darwish
  0 siblings, 0 replies; 2+ messages in thread
From: Ahmed S. Darwish @ 2007-10-09 13:32 UTC (permalink / raw)
  To: Akinobu Mita, linux-kernel, Mike Travis, Andrew Morton

On Tue, Oct 09, 2007 at 07:43:21PM +0900, Akinobu Mita wrote:
> This patch fixes the problem introduced by:
> http://kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc8/2.6.23-rc8-mm2/broken-out/x86-convert-cpuinfo_x86-array-to-a-per_cpu-array.patch
> 

Link is dead, same patch in lkml.org:

http://lkml.org/lkml/2007/9/24/394

-- 
Ahmed S. Darwish
HomePage: http://darwish.07.googlepages.com
Blog: http://darwish-07.blogspot.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-10-09 13:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-09 10:43 [PATCH -mm] fix wrong /proc/cpuinfo output Akinobu Mita
2007-10-09 13:32 ` Ahmed S. Darwish

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox