Re: [PATCH v2] powerpc: don't enable cpu hotplug on mpic-based pseries

Paul Mackerras
2007-10-11T05:52:19Z

Olof Johansson writes:

> Don't allow cpu hotplug on systems lacking XICS interrupt controller,
> since current code is hardcoded for it.
...
> + for (np = NULL; (np = of_find_node_by_name(np,
> + "interrupt-controller"));) {

Looks like for_each_node_by_name would be nicer here.

If you agree, I'll hand-edit your patch to do that and apply it. Of
course, ultimately we should implement the necessary mpic bits to
support cpu hotplug.

Paul.