Re: coding for optimizations (Re: [PATCH 1/2] i386: mce cleanup part1: functional change)

Adrian Bunk
2007-10-11T15:21:16Z

On Thu, Oct 11, 2007 at 05:26:09PM +0200, Oleg Verych wrote:
> On Thu, Oct 11, 2007 at 01:14:29AM +0200, Adrian Bunk wrote:
> []
> > It's also a quite ill idea to think about whether gcc might produce a
> > few bytes more or less code at the if when there's such a long printk()
> > in the middle...
>
> printk() problem was discussed with proper banana userspace replacement
> proposition by me, so i don't care much.
>
> Though, why MCE can't be enabled/disabled by config option? Native
> engineers from proper company should know what processors have this
> feature... If kconfig isn't flexible for this, i'm glad to hear
> opinions. If it's needed anyway, then sorry.

You should better say sorry for not having checked that it can already
be disabled with a kconfig option...

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed