From: Sam Ravnborg <sam@ravnborg.org>
To: Jeff Dike <jdike@addtoit.com>
Cc: Andi Kleen <andi@firstfloor.org>,
kbuild devel <kbuild-devel@lists.sourceforge.net>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC/RFT] kbuild: save ARCH & CROSS_COMPILE
Date: Tue, 9 Oct 2007 18:34:35 +0200 [thread overview]
Message-ID: <20071009163435.GA25408@uranus.ravnborg.org> (raw)
In-Reply-To: <20071009140906.GA4942@c2.user-mode-linux.org>
On Tue, Oct 09, 2007 at 10:09:06AM -0400, Jeff Dike wrote:
> On Tue, Oct 09, 2007 at 12:00:30PM +0200, Sam Ravnborg wrote:
> > If it is OK to drop the $(SUBARCH) assingment like this then yes.
> > ARCH ?=
> > CROSS_COMPILE ?=
>
> Does the UML build still work when you do that?
The original behaviour is kept is ARCH is not set on the
commandline and saved in .kbuild (Kbuild.config in the patch).
The logic goes basically like this:
If there is no .kbuild file then set ARCH = $(SUBARCH)
else set ARCH = saved ARCH from .kbuild.
And then a bit sanity check that the user does not
try to change architecture in the middle.
I actually used um as testing ground for this patch so
it works for um in my way of building um.
I considered switching architectures automagically
but concluded that in most cases when a user change ARCH
then that's because the user forgot to specify ARCH or more
seldom forgot what ARCH was being built in that directory.
Sam
next prev parent reply other threads:[~2007-10-09 16:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-08 20:02 [RFC/RFT] kbuild: save ARCH & CROSS_COMPILE Sam Ravnborg
2007-10-08 20:50 ` Oleg Verych
2007-10-09 4:17 ` Sam Ravnborg
2007-10-09 4:53 ` Randy Dunlap
2007-10-09 5:28 ` Randy Dunlap
2007-10-09 6:01 ` Sam Ravnborg
2007-10-09 8:37 ` Oleg Verych
2007-10-08 21:12 ` Adrian Bunk
2007-10-08 21:20 ` Giacomo Catenazzi
2007-10-09 6:03 ` Sam Ravnborg
2007-10-09 9:54 ` Adrian Bunk
2007-10-09 9:39 ` Andi Kleen
2007-10-09 10:00 ` Sam Ravnborg
2007-10-09 11:08 ` Andi Kleen
2007-10-09 14:09 ` Jeff Dike
2007-10-09 16:34 ` Sam Ravnborg [this message]
2007-10-09 17:44 ` Jeff Dike
2007-10-10 2:35 ` Kristoffer Ericson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071009163435.GA25408@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=andi@firstfloor.org \
--cc=jdike@addtoit.com \
--cc=kbuild-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox