Re: 2.6.23-rc8-mm2: problems on HP nx6325

Rafael J. Wysocki
2007-09-27T15:45:40Z

On Thursday, 27 September 2007 17:19, Rafael J. Wysocki wrote:
> On Thursday, 27 September 2007 11:22, Andrew Morton wrote:
> >
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc8/2.6.23-rc8-mm2/
> >
> >
> > - The scheduler devel tree has been restored
> >
> > - The driver tree is presently busted, so I reverted it to the 2..23-rc8-mm1
> > version.
> >
> > - It's now a nearly-32MB diff.
>
> On HP nx6325:
>
> 1) The audio is back (thanks for reverting x86_64-mm-cpa-einval.patch)
>
> 2) CPU hotplug is busted (onlining of CPU1 kills the kernel), probably due to
> the same issue that I'm having with the -hrt version of 2.6.23-rc8 (we're
> debugging it right now)

This one is fixed by the following patch:

---
From: Rafael J. Wysocki <rjw@sisk.pl>

Fix CPU hotplug breakage on HP nx6325 and similar boxes caused by a reference
to disable_apic_timer (labeled as __initdata) from the CPU initialization code.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
arch/x86_64/kernel/apic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.23-rc8-mm2/arch/x86_64/kernel/apic.c
===================================================================
--- linux-2.6.23-rc8-mm2.orig/arch/x86_64/kernel/apic.c
+++ linux-2.6.23-rc8-mm2/arch/x86_64/kernel/apic.c
@@ -42,7 +42,7 @@

int apic_verbosity;
static int apic_calibrate_pmtmr __initdata;
-int disable_apic_timer __initdata;
+int disable_apic_timer __cpuinitdata;

/* Local APIC timer works in C2? */
int local_apic_timer_c2_ok;