Re: 2.6.23-rc8-mm2: problems on HP nx6325

Randy Dunlap
2007-09-27T17:35:45Z

On Thu, 27 Sep 2007 18:53:46 +0200 Sam Ravnborg wrote:

> Hi Rafael.
> >
> > Fix CPU hotplug breakage on HP nx6325 and similar boxes caused by a reference
> > to disable_apic_timer (labeled as __initdata) from the CPU initialization code.
> >
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> > ---
> > arch/x86_64/kernel/apic.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Index: linux-2.6.23-rc8-mm2/arch/x86_64/kernel/apic.c
> > ===================================================================
> > --- linux-2.6.23-rc8-mm2.orig/arch/x86_64/kernel/apic.c
> > +++ linux-2.6.23-rc8-mm2/arch/x86_64/kernel/apic.c
> > @@ -42,7 +42,7 @@
> >
> > int apic_verbosity;
> > static int apic_calibrate_pmtmr __initdata;
> > -int disable_apic_timer __initdata;
> > +int disable_apic_timer __cpuinitdata;
> >
> This is with your configuration a reference from a .text section
> to a .init.data section as I see it.
>
> So this ought to have been flagged by the section mismatch
> checks in modpost.
>
> I assume you did not see such warning??

I did:

WARNING: vmlinux.o(.text+0x7778): Section mismatch: reference to .init.data:disable_apic_timer (between 'identify_cpu' and 'IRQ0x20_interrupt')

---
~Randy
Phaedrus says that Quality is about caring.