From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755606AbXJITRv (ORCPT ); Tue, 9 Oct 2007 15:17:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752805AbXJITRo (ORCPT ); Tue, 9 Oct 2007 15:17:44 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:34242 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752754AbXJITRn (ORCPT ); Tue, 9 Oct 2007 15:17:43 -0400 Date: Tue, 9 Oct 2007 21:17:31 +0200 From: Ingo Molnar To: Andi Kleen Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] [1/6] scheduler: Remove some unnecessary gotos in sched.c Message-ID: <20071009191730.GA8887@elte.hu> References: <200710071059.126674000@suse.de> <20071007205954.4053C13E06@wotan.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071007205954.4053C13E06@wotan.suse.de> User-Agent: Mutt/1.5.14 (2007-02-12) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.1.7-deb -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org * Andi Kleen wrote: > No need to be more spagetti than absolutely necessary. > > Replace loops implemented with gotos with real loops. Replace err = > ...; goto x; x: return err; with return ...; > > No functional changes. this crashes during bootup - removed it for now. Ingo