Re: [PATCH] [2/6] scheduler: Refactor common code of sleep_on / wait_for_completion v2

Ingo Molnar
2007-10-08T12:03:27Z

* Ingo Molnar <mingo@elte.hu> wrote:

> * Andi Kleen <andi@firstfloor.org> wrote:
>
> > Andi Kleen <ak@suse.de> writes:
> >
> > > These functions were largely cut'n'pasted. This moves
> >
> > Here's a replacement patch fixing a minor problem:
> > sleep_on_common wasn't marked __sched and ended up in the
> > wrong section; breaking the WCHAN backtracing.
>
> thanks, applied.

btw., this is a very nice cleanup, the .text savings are particularly
impressive:

text data bss dec hex filename
24545 2406 16 26967 6957 sched.o.before
23687 2406 16 26109 65fd sched.o.after

almost 1K of text shaven off! :)

Ingo