From: Andi Kleen <ak@suse.de>
To: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
Cc: akpm@linux-foundation.org, yanmin.zhang@intel.com,
vgoyal@in.ibm.com, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [patch] x86_64, vsyscall: fix the oops crash with __pa_vsymbol()
Date: Wed, 10 Oct 2007 15:36:58 +0200 [thread overview]
Message-ID: <200710101536.59156.ak@suse.de> (raw)
In-Reply-To: <20071010015922.GC30676@linux-os.sc.intel.com>
On Wednesday 10 October 2007 03:59:22 Siddha, Suresh B wrote:
> Appended patch fixes an oops while changing the vsyscall sysctl.
> I am sure no one tested this code before integrating into mainline :(
The original code worked, but got broken by 0dbf7028c0c1f266c9631139450a1502d3cd457e
>
> BTW, using ioremap() in vsyscall_sysctl_change() to get the virtual
> address of a kernel symbol sounds like an over kill.
Another point was to get a writable mapping. At some point we had write
protected kernels, although that was later then removed again.
> And also, the whole nop out syscall in vsyscall page infrastructure
> (vsyscall_sysctl_change()) is added to make some attacks difficult,
> and yet I don't see this nop out being done by default. This area
> requires more cleanups?
It used to be done, but it is difficult with the changing vreads
in timesources and was probably disabled then. Yes you're right right now
it looks dubious.
It needs to be updated when the timesource is updated.
-Andi
next prev parent reply other threads:[~2007-10-10 13:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-10 1:59 [patch] x86_64, vsyscall: fix the oops crash with __pa_vsymbol() Siddha, Suresh B
2007-10-10 13:36 ` Andi Kleen [this message]
2007-10-11 5:31 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710101536.59156.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=vgoyal@in.ibm.com \
--cc=yanmin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox