public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@redhat.com>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Michael Krufky <mkrufky@linuxtv.org>,
	video4linux-list@redhat.com, Jiri Slaby <jirislaby@gmail.com>,
	daniel@qanu.de, linux-kernel@vger.kernel.org, holger@qanu.de,
	v4l-dvb maintainer list <v4l-dvb-maintainer@linuxtv.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [v4l-dvb-maintainer] [PATCH 3/3] V4L: cinergyT2, remove bad usage of ERESTARTSYS
Date: Wed, 10 Oct 2007 11:59:20 -0400	[thread overview]
Message-ID: <20071010155920.GC22618@devserv.devel.redhat.com> (raw)
In-Reply-To: <1192030541.5896.54.camel@gaivota>

On Wed, Oct 10, 2007 at 12:35:41PM -0300, Mauro Carvalho Chehab wrote:
> Em Qua, 2007-10-10 às 00:18 -0400, Michael Krufky escreveu:
> > 
> > Is this illegal as per kernel codingstyle?
> 
> Yes, it is. CodingStyle states:

<rant>
No.. "Illegal" means prohibited by law. Its merely wrong 8)
</rant>

> The proper fix is just to replace the offended code by this:
> 
> err=foo();
> if (error)
> 	goto error;

Lots of code uses

	if ((err = foo()) < 0)

so I would'y worry too much. The split one however clearer and also
safer.


  reply	other threads:[~2007-10-10 15:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-08 12:33 [PATCH 1/3] V4L: w9968cf, remove bad usage of ERESTARTSYS Jiri Slaby
2007-10-08 12:34 ` [PATCH 2/3] V4L: zc0301, " Jiri Slaby
2007-10-10  0:18   ` Luca Risolia
2007-10-08 12:34 ` [PATCH 3/3] V4L: cinergyT2, " Jiri Slaby
2007-10-10  1:21   ` Mauro Carvalho Chehab
2007-10-10  4:18     ` [v4l-dvb-maintainer] " Michael Krufky
2007-10-10 15:35       ` Mauro Carvalho Chehab
2007-10-10 15:59         ` Alan Cox [this message]
2007-10-10 16:17           ` Mauro Carvalho Chehab
2007-10-10 16:40             ` Manu Abraham
2007-10-10 16:53               ` Marcel Siegert
2007-10-10 17:05                 ` Manu Abraham
2007-10-10 18:04                   ` Marcel Siegert
2007-10-12  4:29       ` Randy Dunlap
2007-10-10  0:18 ` [PATCH 1/3] V4L: w9968cf, " Luca Risolia
2007-10-14 14:28 ` [PATCH 1/1 try 2] V4L: cinergyT2, " Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071010155920.GC22618@devserv.devel.redhat.com \
    --to=alan@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=daniel@qanu.de \
    --cc=holger@qanu.de \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=mkrufky@linuxtv.org \
    --cc=v4l-dvb-maintainer@linuxtv.org \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox