Re: parisc arch makefile clean-up needed [Was: cleaning up "make headers_install" for various architectures]

Kyle McMartin
2007-10-10T19:38:41Z

On Wed, Oct 10, 2007 at 08:38:58PM +0200, Sam Ravnborg wrote:
> parisc arch Makefile needs some love and care...
>

It basically hasn't been touched since 2.4, I already have a patch to
clean up a lot of things when Randy pointed it out a while ago. Thanks
for the reminder, I'll queue it for 2.6.24.

Regards,
Kyle

> The logic selecting CROSS_COMPILE seems fishy and wrong -
> the error reported by rday is obvious in this respect.
>
> FINAL_LD is unused - kill it.
>
> Building with oldpalo has been broken for a loong time - time to kill it?
> Hint - the "cd ../palo" is not working as expected.
> And use of TOPDIR is deprecated.
>
> The libs-y assignment should learn from the other architectures how to
> get the gcc lib filename:
> $(shell $(CC) $(CFLAGS) -print-libgcc-file-name)
>
>
> And this snippet is also wrong:
> PALO := $(shell if which palo; then : ; \
> elif [ -x /sbin/palo ]; then echo /sbin/palo; \
> fi)
>
> palo: vmlinux
> @if [ -x $PALO ]; then \
>
>
> Make does not export variables so $PALO is not the same as $(PALO).
> The latter should be used.
>
> I did not supply a patch because I do not fully understand the
> logic behind setting CROSS_COMPILE and 64BIT or not.
> But I will be happy to review a patch to fix the issues in the
> parisc Makefile.

I'll add this to the patch as well.