From: David Miller <davem@davemloft.net>
To: rob@landley.net
Cc: bunk@kernel.org, James.Bottomley@steeleye.com,
linux-scsi@vger.kernel.org, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] esp_scsi.c: remove __dev{init,exit}
Date: Thu, 11 Oct 2007 14:49:28 -0700 (PDT) [thread overview]
Message-ID: <20071011.144928.45188136.davem@davemloft.net> (raw)
In-Reply-To: <200710111747.03119.rob@landley.net>
From: Rob Landley <rob@landley.net>
Date: Thu, 11 Oct 2007 17:47:02 -0500
> On Thursday 11 October 2007 10:35:20 am Adrian Bunk wrote:
> > Since scsi_esp_{,un}register() are EXPORT_SYMBOL'ed, these functions
> > (and the functions they use) can't be __dev{init,exit}.
> >
> > Based on a bug report by Rob Landley.
> >
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> Acked-by: Rob Landley <rob@landley.net>
I'm fine with this fix too.
Acked-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2007-10-11 21:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-11 10:52 Scsi on sparc build break in 2.6.23 Rob Landley
2007-10-11 11:05 ` Adrian Bunk
2007-10-11 13:17 ` Rob Landley
2007-10-11 13:30 ` James Bottomley
2007-10-11 15:35 ` [2.6 patch] esp_scsi.c: remove __dev{init,exit} Adrian Bunk
2007-10-11 22:47 ` Rob Landley
2007-10-11 21:49 ` David Miller [this message]
2007-10-18 8:18 ` Rob Landley
2007-10-11 15:21 ` Scsi on sparc build break in 2.6.23 Adrian Bunk
[not found] ` <200710111737.30420.rob@landley.net>
2007-10-11 23:56 ` Adrian Bunk
2007-10-12 0:10 ` Randy Dunlap
2007-10-13 19:09 ` Rob Landley
2007-10-13 19:26 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071011.144928.45188136.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=James.Bottomley@steeleye.com \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rob@landley.net \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox