From: Greg KH <greg@kroah.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Andi Kleen <ak@suse.de>, LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 2/2] X86: Introduce and enable PCI domain support
Date: Thu, 11 Oct 2007 14:45:13 -0700 [thread overview]
Message-ID: <20071011214513.GA9807@kroah.com> (raw)
In-Reply-To: <20071011214028.GC32752@kroah.com>
On Thu, Oct 11, 2007 at 02:40:28PM -0700, Greg KH wrote:
> On Thu, Oct 11, 2007 at 04:58:30PM -0400, Jeff Garzik wrote:
> >
> > * fix bug in pci_read() and pci_write() which prevented PCI domain
> > support from working (hardcoded domain 0).
> >
> > * unconditionally enable CONFIG_PCI_DOMAINS
> >
> > * implement pci_domain_nr() and pci_proc_domain(), as required of
> > all arches when CONFIG_PCI_DOMAINS is enabled.
> >
> > * store domain in struct pci_sysdata, as assigned by ACPI
> >
> > * support "pci=nodomains"
> >
> > Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
> > ---
> > Revised per Andi's comments, and split into two patches.
>
> Ugh:
> In file included from include/linux/pci.h:785,
> from drivers/pci/access.c:2:
> include/asm/pci.h:16: error: redefinition of 'pci_domain_nr'
> include/linux/pci.h:692: error: previous definition of 'pci_domain_nr' was here
> include/asm/pci.h:22: error: redefinition of 'pci_proc_domain'
> include/linux/pci.h:694: error: previous definition of 'pci_proc_domain' was here
> make[1]: *** [drivers/pci/access.o] Error 1
>
> I'll see if I can fix it up...
Hm, sorry, my fault, error with not upadating the config...
nevermind...
greg k-h
next prev parent reply other threads:[~2007-10-11 21:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-11 20:57 [PATCH v2 1/2] PCI: Add 'nodomains' boot option, and pci_domains_supported global Jeff Garzik
2007-10-11 20:58 ` [PATCH v2 2/2] X86: Introduce and enable PCI domain support Jeff Garzik
2007-10-11 21:40 ` Greg KH
2007-10-11 21:45 ` Greg KH [this message]
2007-10-11 21:17 ` [PATCH v2 1/2] PCI: Add 'nodomains' boot option, and pci_domains_supported global Jeff Garzik
2007-10-11 21:38 ` Greg KH
2007-10-11 21:50 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071011214513.GA9807@kroah.com \
--to=greg@kroah.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox