From: David Brownell <david-b@pacbell.net>
To: Bryan Wu <bryan.wu@analog.com>
Cc: spi-devel-general@lists.sourceforge.net,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Michael Hennerich <michael.hennerich@analog.com>
Subject: Re: [PATCH 02/10] Blackfin SPI driver: use new GPIO API and add error handling
Date: Thu, 11 Oct 2007 23:26:34 -0700 [thread overview]
Message-ID: <200710112326.34500.david-b@pacbell.net> (raw)
In-Reply-To: <1192158304-8277-3-git-send-email-bryan.wu@analog.com>
On Thursday 11 October 2007, Bryan Wu wrote:
> @@ -1182,12 +1198,9 @@ static int __init bfin5xx_spi_probe(struct platform_device *pdev)
> return -ENOMEM;
> }
>
> - if (peripheral_request(P_SPI0_SCK, DRV_NAME) ||
> - peripheral_request(P_SPI0_MISO, DRV_NAME) ||
> - peripheral_request(P_SPI0_MOSI, DRV_NAME) ) {
> -
> + if (setup_pin_mux(1)) {
> dev_err(&pdev->dev, ": Requesting Peripherals failed\n");
> - goto out_error_queue_alloc;
> + goto out_error;
> }
>
> drv_data = spi_master_get_devdata(master);
>
Still doesn't apply ... what tree are you generating this series against??
next prev parent reply other threads:[~2007-10-12 6:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-12 3:04 [PATCH 00/10] Blackfin SPI driver updates for 2.6.24 Bryan Wu
2007-10-12 3:04 ` [PATCH 01/10] Blackfin SPI driver: Initial supporting BF54x in SPI driver Bryan Wu
2007-10-12 3:04 ` [PATCH 02/10] Blackfin SPI driver: use new GPIO API and add error handling Bryan Wu
2007-10-12 6:26 ` David Brownell [this message]
2007-10-12 6:54 ` Bryan Wu
2007-10-12 17:17 ` David Brownell
2007-10-14 17:06 ` Wu, Bryan
2007-10-18 6:06 ` Bryan Wu
2007-10-19 17:57 ` David Brownell
2007-10-12 3:04 ` [PATCH 03/10] Blackfin SPI driver: add error handing Bryan Wu
2007-10-12 3:04 ` [PATCH 04/10] Blackfin SPI driver: Blackfin SPI driver does not respect the per-transfer cs_change field Bryan Wu
2007-10-12 3:04 ` [PATCH 05/10] Blackfin SPI driver: prevent people from setting bits in ctl_reg Bryan Wu
2007-10-12 3:05 ` [PATCH 06/10] Blackfin SPI driver: update spi driver to support multi-ports Bryan Wu
2007-10-12 3:05 ` [PATCH 07/10] Blackfin SPI driver: Add SPI master controller platform device 1 Bryan Wu
2007-10-12 3:05 ` [PATCH 08/10] Blackfin SPI driver: Move GPIO config to setup and cleanup Bryan Wu
2007-10-12 3:05 ` [PATCH 09/10] Blackfin SPI driver: Fix SPI driver to work with SPI flash ST25P16 on bf548 Bryan Wu
2007-10-12 3:05 ` [PATCH 10/10] Blackfin SPI driver: Clean up useless wait in bfin SPI driver Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710112326.34500.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=akpm@linux-foundation.org \
--cc=bryan.wu@analog.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox