[PATCH] irlmp_unregister_link needs to free lsaps hashbin

[PATCH] irlmp_unregister_link needs to free lsaps hashbin

[hinko.kocevar]

[-- Attachment #1: Type: text/plain, Size: 309 bytes --]

Hi,

While testing the mcs7780 based IrDA USB dongle I've stumbled upon
memory leak in irlmp_unregister_link(). Hashbin for lsaps is created in
irlmp_register_link and should probably be freed in irlmp_unregister_link().

Signed-off-by: Hinko Kocevar <hinko.kocevar@cetrtapot.si>

Best regards,
Hinko

----



[-- Attachment #2: irlmp-delete-lsaps-hashbin.diff --]
[-- Type: text/plain, Size: 355 bytes --]

--- linux-2.6.23/net/irda/irlmp.c.orig	2007-10-12 14:05:17.000000000 +0200
+++ linux-2.6.23/net/irda/irlmp.c	2007-10-12 14:05:41.000000000 +0200
@@ -353,6 +353,7 @@ void irlmp_unregister_link(__u32 saddr)
 		/* Final cleanup */
 		del_timer(&link->idle_timer);
 		link->magic = 0;
+		hashbin_delete(link->lsaps, (FREE_FUNC) kfree);
 		kfree(link);
 	}
 }

Re: [irda-users] [PATCH] irlmp_unregister_link needs to free lsaps hashbin

[Samuel Ortiz]

Hi Hinko,

On Fri, Oct 12, 2007 at 02:56:27PM +0200, hinko.kocevar@cetrtapot.si wrote:
> Hi,
> 
> While testing the mcs7780 based IrDA USB dongle I've stumbled upon
> memory leak in irlmp_unregister_link(). Hashbin for lsaps is created in
> irlmp_register_link and should probably be freed in irlmp_unregister_link().
> 
> Signed-off-by: Hinko Kocevar <hinko.kocevar@cetrtapot.si>
> 
> Best regards,
> Hinko
> 
> ----
> 
> 

> --- linux-2.6.23/net/irda/irlmp.c.orig	2007-10-12 14:05:17.000000000 +0200
> +++ linux-2.6.23/net/irda/irlmp.c	2007-10-12 14:05:41.000000000 +0200
> @@ -353,6 +353,7 @@ void irlmp_unregister_link(__u32 saddr)
>  		/* Final cleanup */
>  		del_timer(&link->idle_timer);
>  		link->magic = 0;
> +		hashbin_delete(link->lsaps, (FREE_FUNC) kfree);
Good catch, but I think the right fix sould be:
+             hashbin_delete(link->lsaps, (FREE_FUNC) __irlmp_close_lsap);

and I'll forward it. Thanks a lot.

Cheers,
Samuel.


>  		kfree(link);
>  	}
>  }

> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc.
> Still grepping through log files to find problems?  Stop.
> Now Search log events and configuration files using AJAX and a browser.
> Download your FREE copy of Splunk now >> http://get.splunk.com/
> _______________________________________________
> irda-users mailing list
> irda-users@lists.sourceforge.net
> http://lists.sourceforge.net/lists/listinfo/irda-users

Re: [irda-users] [PATCH] irlmp_unregister_link needs to free lsaps hashbin

[hinko.kocevar]

Samuel Ortiz wrote:
> Hi Hinko,
> 
> On Fri, Oct 12, 2007 at 02:56:27PM +0200, hinko.kocevar@cetrtapot.si wrote:
>> Hi,
>>
>> While testing the mcs7780 based IrDA USB dongle I've stumbled upon
>> memory leak in irlmp_unregister_link(). Hashbin for lsaps is created in
>> irlmp_register_link and should probably be freed in irlmp_unregister_link().
>>
>> Signed-off-by: Hinko Kocevar <hinko.kocevar@cetrtapot.si>
>>
>> Best regards,
>> Hinko
>>
>> ----
>>
>>
> 
>> --- linux-2.6.23/net/irda/irlmp.c.orig	2007-10-12 14:05:17.000000000 +0200
>> +++ linux-2.6.23/net/irda/irlmp.c	2007-10-12 14:05:41.000000000 +0200
>> @@ -353,6 +353,7 @@ void irlmp_unregister_link(__u32 saddr)
>>  		/* Final cleanup */
>>  		del_timer(&link->idle_timer);
>>  		link->magic = 0;
>> +		hashbin_delete(link->lsaps, (FREE_FUNC) kfree);
> Good catch, but I think the right fix sould be:
> +             hashbin_delete(link->lsaps, (FREE_FUNC) __irlmp_close_lsap);
> 

You're probably right since struct lsap_cb get inserted into the hashbin.

Regards,
Hinko

-- 
ČETRTA POT, d.o.o., Kranj
Planina 3
4000 Kranj
Slovenia, Europe
Tel. +386 (0) 4 280 66 03
E-mail: hinko.kocevar@cetrtapot.si
Http: www.cetrtapot.si