Re: [2.6.20.21 review 12/35] TCP: Fix TCP handling of SACK in bidirectional flows.

Adrian Bunk
2007-10-13T17:50:23Z

On Sat, Oct 13, 2007 at 07:22:14PM +0200, Willy Tarreau wrote:
>...
> Thanks for your help, I really appreciate it. In fact, I've reviewed them
> four, but two of them did not apply and the code looked somewhat different,
> so I considered them irrelevant to 2.6.20. I didn't understand that they
> were all related, so maybe I checked them in a wrong order.
>
> I'll recheck all that in the right sequence and will merge them four, or
> get back to you if something still puzzles me.

I discussed this issue with Ilpo just yesterday regarding 2.6.16, and
the result of our discussion was that I reverted it.

TCP being in some situations a bit more conservative than it should be
isn't a big issue and not worth backporting with a risk of introducing
a regression.

I'd recommend you simply drop the two patches for 2.6.20.

> Thanks!
> Willy

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed